Closed
Bug 860622
Opened 12 years ago
Closed 12 years ago
Stop preprocessing browser/base/content/pageinfo/pageInfo.js
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 23
People
(Reporter: ttaubert, Assigned: ttaubert)
Details
Attachments
(1 file)
1.78 KB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Comment 2•12 years ago
|
||
Comment on attachment 736150 [details] [diff] [review]
stop preprocessing browser/base/content/pageinfo/pageInfo.js
driveby *yoink*.
r+ assuming you were also going to fix the preprocessed header of pageInfo.js. Otherwise this wouldn't seem to work so well... :)
Attachment #736150 -
Flags: review?(dao) → review+
Comment 3•12 years ago
|
||
* preprocessed license header, I meant to say.
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #2)
> r+ assuming you were also going to fix the preprocessed header of
> pageInfo.js. Otherwise this wouldn't seem to work so well... :)
Darn, I didn't actually take a look at pageInfo.js. How about wrapping the license boilerplate in #ifdef 0 | #endif instead of not preprocessing it anymore?
Assignee | ||
Comment 5•12 years ago
|
||
As discussed on IRC, I just converted the license header to be a normal JS comment.
https://hg.mozilla.org/integration/fx-team/rev/8a7fdc4019c8
Assignee | ||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in
before you can comment on or make changes to this bug.
Description
•