Stop preprocessing browser/base/content/pageinfo/pageInfo.js

RESOLVED FIXED in Firefox 23

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 23
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 736150 [details] [diff] [review]
stop preprocessing browser/base/content/pageinfo/pageInfo.js
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #736150 - Flags: review?(dao)
Comment on attachment 736150 [details] [diff] [review]
stop preprocessing browser/base/content/pageinfo/pageInfo.js

driveby *yoink*.

r+ assuming you were also going to fix the preprocessed header of pageInfo.js. Otherwise this wouldn't seem to work so well... :)
Attachment #736150 - Flags: review?(dao) → review+
* preprocessed license header, I meant to say.
(Assignee)

Comment 4

6 years ago
(In reply to Justin Dolske [:Dolske] from comment #2)
> r+ assuming you were also going to fix the preprocessed header of
> pageInfo.js. Otherwise this wouldn't seem to work so well... :)

Darn, I didn't actually take a look at pageInfo.js. How about wrapping the license boilerplate in #ifdef 0 | #endif instead of not preprocessing it anymore?
(Assignee)

Comment 5

6 years ago
As discussed on IRC, I just converted the license header to be a normal JS comment.

https://hg.mozilla.org/integration/fx-team/rev/8a7fdc4019c8
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/8a7fdc4019c8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in before you can comment on or make changes to this bug.