860622 - Stop preprocessing browser/base/content/pageinfo/pageInfo.js

Status: RESOLVED FIXED

(Firefox :: General, defect)

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: stop preprocessing browser/base/content/pageinfo/pageInfo.js

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 736150 [details] [diff] [review]
stop preprocessing browser/base/content/pageinfo/pageInfo.js

driveby *yoink*.

r+ assuming you were also going to fix the preprocessed header of pageInfo.js. Otherwise this wouldn't seem to work so well... :)

Comment 3

[Justin Dolske [:Dolske]]

* preprocessed license header, I meant to say.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Justin Dolske [:Dolske] from comment #2)
> r+ assuming you were also going to fix the preprocessed header of
> pageInfo.js. Otherwise this wouldn't seem to work so well... :)

Darn, I didn't actually take a look at pageInfo.js. How about wrapping the license boilerplate in #ifdef 0 | #endif instead of not preprocessing it anymore?

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

As discussed on IRC, I just converted the license header to be a normal JS comment.

https://hg.mozilla.org/integration/fx-team/rev/8a7fdc4019c8

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/8a7fdc4019c8