Closed
Bug 860642
Opened 12 years ago
Closed 11 years ago
Move the definitions of built-in widgets to their own file
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: Unfocused, Assigned: mconley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:M5])
Attachments
(1 file)
|
18.34 KB,
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
The definitions for the built-in widgets in CustomizableUI.jsm is getting rather long - for the sake of sanity for anyone working on this, I think we should move the definitions to their own file.
There's a few options for doing that:
* Preprocess the new file into CustomizableUI.jsm
* Load the new file as a JSM
* Load the new file as a subscript
* Define in a .json (or .widget) file, load via the infrastructure originally setup for widgets registered via an add-ons chrome.manifest
|
Assignee | |
Updated•12 years ago
|
Blocks: australis-cust
|
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → mconley
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•12 years ago
|
Attachment #750034 -
Attachment description: Patch v1.4 → Patch v1
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 750034 [details] [diff] [review]
Patch v1
Let's try the JSM route.
Attachment #750034 -
Flags: review?(bmcbride)
|
Reporter | |
Updated•12 years ago
|
Attachment #750034 -
Flags: review?(bmcbride) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Whiteboard: [Australis:M5] → [Australis:M5][fixed-in-ux]
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M5][fixed-in-ux] → [Australis:M5]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•