860663 - [Bluetooth][Certification]HFP PTS test TC_AG_OCM_BV_01_I test case fail

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Memory dialing does not correctly support.
ATD>1 does not support.

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Nominate as a leo+ since we got inquiry from leo.

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Add memory dialing feature to pass TC_AG_OCM_BV_01_I test case

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Add memory dialing feature to pass TC_AG_OCM_BV_01_I test case

Comment 4

[Alex Keybl [:akeybl]]

This needs more context - what's the user impact if left unfixed?

Comment 5

[Gina Yeh [:gyeh] [:ginayeh]]

I think this patch is for hfp certification. In the current implementation, we reply "ERROR" whenever Bluetooth Headset send memory dialing command (ex. ATD>1) to us. 

However, we don't support memory dialing in Dialer app and Shawn is trying to replace the memory dialing request with redial request. This is an workaround, but should be helpful for certification.

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 860663 Implement memory dialing

Comment 7

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 736686 [details] [diff] [review]
Bug 860663 Implement memory dialing

Review of attachment 736686 [details] [diff] [review]:
-----------------------------------------------------------------

Some details from BLUETOOTH SPECIFICATION Hands-free Profile 1.6, 4.19 Memory Dialing from the HF.

1. If there is no number stored for the memory location given by the HF, the AG shall respond with ERROR. 

2. If the AG supports the "Three-way calling" feature and if a call is already ongoing in the AG, performing this procedure shall result in a new call being placed to a third party with the current ongoing call put on hold.





I'd like to point out something here.

For point 1, how can we verify whether the memory location given by HF is valid or not? Since we don't support memory dialing feature in Dialer app, no way for us to verity that for sure. I would suggest to write a comment here, and we can go back to implement this part someday.

For point 2, luckily, the behaviour of current Dialer app is exactly the same with what the spec describes.

Comment 8

[Wayne Chang [:wchang]]

Triage 4/12 - Leo+ for certification.

Comment 9

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Hi Wayne,
This required to change dialer app to support memory dialing. Please help to check this is required to have leo+ in the triage meeting.

Comment 10

[Alex Keybl [:akeybl]]

needinfo on ffos-product for comment 9

Comment 11

[Peter Dolanjski [:pdol]]

Memory dialing in the dialer app is not in scope for leo.
Given this, I suspect that a waiver can be given for this feature via BlueTooth.  Please confirm during triage with leo partner.

Comment 12

[Alex Keybl [:akeybl]]

Discussed in triage - leo will discuss with QE engineers about the need for a waiver here.

Comment 13

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Any update? Also, we can expect this also happened with tef line.

Comment 14

[leo.bugzilla.gecko]

Dear Mozilla Team,

I know that memory dialing is not supported in leo.
So this HFP case was replaced by the last dial for bluetooth certification and there is no problem.

Thanks.

Comment 15

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Base on Comment 14, re-nominate leo?

Comment 16

[Joe Cheng [:jcheng] (please needinfo)]

this is needed for tef to pass BT cert. tef?

Comment 17

[Daniel Coloma:dcoloma]

I don't understand comment 14 as a request to block on this one but rather the opposite. Can you please clarify if this should be a blocker for certification or not?

Comment 18

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Base on Comment 5 and Comment 14, for certification, we have to use last number redial to implement memory dialing feature. No discussion space here.

Comment 19

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Set due date as IOT1

Comment 20

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

We moved patch to Bug 869296. Once Bug 869296 fixed, this bug also get fixed. Bug 869296 is going to review process.

Comment 21

[Alex Keybl [:akeybl]]

(In reply to Shawn Huang from comment #20)
> We moved patch to Bug 869296. Once Bug 869296 fixed, this bug also get
> fixed. Bug 869296 is going to review process.

I think duping to bug 869296 is the right call in that case.

Comment 22

[Johnny Stenback (:jst)]

Bug 869296 is fixed now, marking this one fixed as well.

Comment 23

[Mila Davydova]

Unable to verify. Lack of resources. Need Bluetooth PTS tool to verify.
Marking as QARegressExclude.