860664 - controller.waitThenClick() does not correctly wait for the element

Status: RESOLVED WORKSFORME

(Testing Graveyard :: Mozmill, defect)

Description

[Andrei Eftimie]

Affected tests:

> /testPreferences/testPasswordSavedAndDeleted.js

Comment 1

[cmtalbert]

Let's find someone to run this test and debug it.

Andreea, want to try this one?

Comment 2

[Andreea Matei [:AndreeaMatei]]

Sure. Assigning myself for now and if it turns out to be something easy I can mentor an enthusiastic contributor :)

Comment 3

[Andreea Matei [:AndreeaMatei]]

I don't get this failure anymore, on Linux and OS X this test passes (both single run and in testrun)

On windows 8, I can only run the test (can't run the setup.py in mozmill-automation because of some "Unable to find vcvarsall.bat" error) and it fails with 
> "could not find element ID: uname"

This is because the test page doesn't get loaded, the test is done in 371ms, it waits very little time at waitForPageLoad().
If I add a sleep of 1000ms, test passes.
Could be bug 760720 here?

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

It sounds like it may be related to bug 760720 then. Was this originally seen on your machine? Could you perhaps try running the test in a loop to see if we can reproduce this.

Comment 5

[Andreea Matei [:AndreeaMatei]]

I believe it was caught on the first round of testruns, on Andrei's mac:
> Password notification should be closed - 'open' should equal 'closed'
> Username has been saved - '' should equal 'bar'
> Password has been saved - '' should equal 'foo'
> There is a saved password - '0' should equal '1'

http://mozmill-crowd.blargon7.com/#/functional/report/cb9e33213cf3d2f37d7b0f8dcc3f87a6

I have sent a reply to the email we wrote then, adding my testruns from today.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I neither can reproduce this on Linux. Andrei please give more details if you are still able to reproduce.

Comment 7

[Andrei Eftimie]

Attachment: Fail log

Still fails for me on OSX (100%).
Attached the log.
Ran with lastest mozmill code and latest Nightly.

Reassigning to myself since it appears only I am affected.

Comment 8

[Andrei Eftimie]

Not sure it depends on bug 760720
With Henrik's latest patch applied I still get the same failure.

Comment 9

[Andrei Eftimie]

We do fail here because we miss a click, but the element appears to exist and be visible when we trigger the click event.

> controller.sleep(300);
Right before this line: http://hg.mozilla.org/qa/mozmill-tests/file/f4370e762026/tests/functional/testPreferences/testPasswordSavedAndDeleted.js#l52

I do see a fadeIn animation on the popup. We might trigger the click event sooner that the animation is finished on OSX.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Also on OS X I do not see this failure. Andrei, please test with the lastest Aurora but not Nightly.

Comment 11

[Andrei Eftimie]

I still get the same failure on Aurora and on Nightly (latest versions, latest code for mozmill and mozmill-tests).

Same short sleep still fixes the issue. Weird that this only happens on my machine.

Comment 12

[Andrei Eftimie]

I've tested on mm-osx-108-3 and works fine there.
It seems safe to assume that the remaining problem is a local one that only affects my machine.

I still have no idea *why* this is happening, and *why* it is affecting only my OSX machine, so we might as well close it with WFM.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Please test with another user on those systems. Might be that an OS setting is interfering here.

Comment 14

[Andrei Eftimie]

Closing with WFM.

New user on the system worked fine.
Seems that either my virtualenv got somehow corrupted, or my pathing or something that would interfere with this. Not sure what. But works fine with a new virtualenv instance.