860677 - Remove already downloaded but not removed updates at the end of update tests

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Automation, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

While investigating bug 803489 I have seen that in cases of aborts already downloaded updates still exist and can cause problems the next time we trigger an update test. We have to remove those files at the end of the testrun.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So we have to retrieve the update path from Firefox and delete everything in the automation script. That re-instantiates bug 842571 in some way.

After digging around I have found that with bug 750554 we got the getUpdatesDirectory() on the AUS service, which certainly helps us here and also could be used to fix bug 842571.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Patch for review. It works fine on Linux, but I will still have to test on OS X and Windows. Dave mind reviewing it already? Also I would appreciate if you could test on OS X given that I don't have an OS X box today. Thanks.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I did further tests on Windows and Mac and on both platforms it works fantastic. We successfully remove the update folder after our tests. On the affected Win8 machine I can't even replicate the jsbridge failure anymore. So it looks like this patch will indeed add a lot more stability to our tests.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 736305 [details] [diff] [review]
Patch v1

Review of attachment 736305 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

http://hg.mozilla.org/qa/mozmill-automation/rev/f2f4250f5bb6