860750 - Autophone - Add support for multiple architectures

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

In bug 821954 we decided to defer adding multiple architecture support for Autophone. We now have the need to support x86 phones. Mark prefers to have a single instance of Autophone deal with multiple architectures so that is what I'll work towards.

Comment 1

[Bob Clary [:bc] (inactive)]

I've been considering ways to get abi information about phones. I can either do it from Autophone by 
shelling out to getprop or could have SUTAgentAndroid.java do the getprop and report it in the registration url. Putting it in SUTAgent seems reasonable. Thoughts?

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: patch v1

This isn't quite what I would have done if starting from scratch, which would have involved a server in autophone that received job commands which were dispatched to each worker to get their own jobs matching the criteria.

Instead, this adds armv6, x86 architectures to the pulse listener in autophone.py and to builds.py so that all arm, armv6 and x86 builds which match the criteria are returned. autophone.py and worker.py filter out incompatible architectures before sending the job to the worker.

I also added some logging to trigger_run.py which sends log messages to the base autophone.log.

Comment 3

[Mark Côté [:mcote]]

Comment on attachment 739088 [details] [diff] [review]
patch v1

Review of attachment 739088 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: worker.py
@@ +434,5 @@
> +            if 'armv6' not in build_url:
> +                incompatible_job = True
> +        else:
> +            if 'x86' in build_url or 'armv6' in build_url:
> +                incompatible_job = True

Can we refactor this into a function that can be used by both autophone and worker?  I worry that we'll want to update this some day and forget to make the change in both locations.

Comment 4

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/4df8067c46f5e73786ef71e27b9adcf7efe60d3c