860802 - Google Docs delaying to close the tab

Status: NEW

(Firefox :: Tabbed Browser, defect)

Description

[Swarnava Sengupta (:Swarnava)]

I dont know much about other sites, but when i trying to close a google doc's tab in between the page become fully load, the tabs are not closing that time and it makes some delay

Example:- https://docs.google.com/spreadsheet/ccc?key=0AjbDkQ2Zlg86dEpqQ2JZa2t1QjV3YTFGTk9DTjdQLUE#gid=0

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

Confirmed against Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130412 Firefox/23.0 ID:20130412030828 CSet: 7b8ed29c6bc0

Tab Opening/Closing Animation is kinda SlowMo, too :-/

SPS for Pageload of above Example: http://people.mozilla.com/~bgirard/cleopatra/#report=70c57480c8b2b7b587d2a860ec652b3dbb9d0f1c

Comment 2

[Andrew Overholt [:overholt]]

I can reproduce on Windows 10 with today's nightly. Mike, WDYT?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

This sounds similar to something the e10s team triaged the other day (bug 1282265). The content process is busy, and so we don't close the tab or window right away.

I _think_ I recall blassey saying that this was intentional. I'm not certain where that work was done though, so redirecting.

Comment 4

[:Gijs (he/him)]

Is this actually specific to e10s? Feels like it might be more general (as it was reported such a long time ago), and have to do with e.g. unload event handlers in the page and what those do.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Mike Conley (:mconley) - (Needinfo me!) from comment #3)
> This sounds similar to something the e10s team triaged the other day (bug
> 1282265). The content process is busy, and so we don't close the tab or
> window right away.
> 
> I _think_ I recall blassey saying that this was intentional. I'm not certain
> where that work was done though, so redirecting.

When I said it was intentional, I meant the code is explicitly waiting for a response to an async message. I didn't mean to imply I remember a conscious decision to do it this way.
(In reply to :Gijs Kruitbosch from comment #4)
> Is this actually specific to e10s? Feels like it might be more general (as
> it was reported such a long time ago), and have to do with e.g. unload event
> handlers in the page and what those do.
Yes and no. The point of e10s is to not let content interfere with the chrome, so in this regard e10s should be held to a higher standard than non-e10s and is failing that standard here.

Comment 6

[Thomas Elin [:relaas]]

Is this bug still reproducible? Reviewing during Platform-rel meeting.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

I don't believe we've done anything to address this bug - we should still be waiting for the "do you have any onbeforeunload event handlers?" message before closing, so this should still be reproducible at the times when the Google Docs/Drive/Spreadsheet page is blocking the content process main thread.

Comment 8

[Mike Taylor [:miketaylr]]

Thanks for the info Mike.