860817 - ensure we pull minidumps from android to the correct location on the host machine

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

it appears we are pulling the /mnt/sdcard/tests/profile/minidump/ directory into a tmp directory:
http://mxr.mozilla.org/mozilla-central/source/build/mobile/remoteautomation.py#126

Then we pass that tmp directory into automation.checkForCrashes:
http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in#1165

the problem is in automation.py.in, we append 'minidumps' to the profile directory, so in this case checkForCrashes finds nothing.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

this problem affect reftest and mochitest, not talos or xpcshell.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

two solutions I can think of:
1) create dumpdir/minidumps, and use that to store the files in, then pass dumpdir to checkForCrashes
2) call mozcrash directly from runtestsremote.py passing in the proper directory to check for.

I prefer #1 although it appears as a much greater hack right now.  If we change our code around checking for crashes outside of mozcrash, we will be able to address it for both desktop and mobile.  Likewise we have self.test_last_seen. 

#2 seems a lot cleaner.

opinions?

Comment 3

[(not currently active) Ted Mielczarek]

Well, right, automation.checkForCrashes takes a "profileDir" argument, and mozcrash just expects "the directory containing minidumps".

Comment 4

[(not currently active) Ted Mielczarek]

You could just make automation.checkForCrashes forward directly to mozcrash.check_for_crashes, and have the non-remote case append the "minidumps" to the profile dir.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: adjust the path to the minidump directory (1.0)

thanks for option #3 ted, this is a simple patch.  Up on try server, hoping for a crash or two.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/750205f3566b