Closed Bug 860844 Opened 11 years ago Closed 11 years ago

[b2g-ril] Allow emergency calls to [000, 08, 110, 999, 118, 119] numbers without ICC card

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: dpalomino, Assigned: jaoo)

References

Details

(Whiteboard: [POVB], Ikura)

Attachments

(1 file, 1 obsolete file)

Issue reported during certification in Spain with Ikura. 

Buildid "20130321070205", device: ikura
gecko commit: b5183c99228bdc5be33340e359efd1b4f0859e92 
gaia commit: 577d13088ebdbd353d13910d3317e713a140415b

The device (without a SIM card) successfully tries to perform emergency calls to 112 or 911. 

However, it is not allowed to do it with following emergency numbers: (000 / 08 / 110 / 999 / 118 / 119)

Thanks!
David
IMHO this is not a bug. Let me explain myself. If the device has a SIM card inserted the RIL stores the list of valid emergency numbers (ril.ecclist) for the country corresponding to the MCC code in the SIM card. If there is no SIM in the device there is no information about the country where the device boots and the list of valid emergency numbers stores a default set of values ([112, 911] the ones you mentioned). If you think about how the approach is that makes sense IMHO.
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #1)
> IMHO this is not a bug. Let me explain myself. If the device has a SIM card
> inserted the RIL stores the list of valid emergency numbers (ril.ecclist)
> for the country corresponding to the MCC code in the SIM card. 

Oops, that's not true. I meant 'for the country corresponding to the MCC code which identifies the network that the device is connected to'.

> If there is
> no SIM in the device there is no information about the country where the
> device boots and the list of valid emergency numbers stores a default set of
> values ([112, 911] the ones you mentioned). If you think about how the
> approach is that makes sense IMHO.
It seems that the issue is because the device (without ICC card) must allow dial any of the emergency numbers in the list [000, 08, 110, 999, 118, 119, 112, 911]. Right now the default list of valid emergency number is [112, 911].
Blocks: b2g-ril
Summary: Not attempted to do emergency calls to (000 / 08 / 110 / 999 / 118 / 119) → [b2g-ril] Allow emergency calls to [000, 08, 110, 999, 118, 119] numbers without ICC card
Assignee: nobody → josea.olivera
Attached patch WIP v1 (obsolete) — Splinter Review
Vicamo, Anshul in order to allow the user to dial any number in the list you can see in the title of this bug we could do what I do in this patch but I cannot work since the rild daemon and libril* library binaries (it seems that) don't allow to dial any number that is not in the [ro.]ril.ecclist list. The thing is that we are limited to dial only to any of the number in the list and thus we cannot fix this issue with this patch and fix it from gecko. Anshul, how could we be able to fix this issue? Thanks!
Attachment #738041 - Flags: feedback?(vyang)
Attachment #738041 - Flags: feedback?(anshulj)
Antonio, let me try to get this information for you.
Comment on attachment 738041 [details] [diff] [review]
WIP v1

Review of attachment 738041 [details] [diff] [review]:
-----------------------------------------------------------------

Since that's etched in an open standard, let's do it :)
Attachment #738041 - Flags: feedback?(vyang) → review+
(In reply to Vicamo Yang (@Telefonica 6F) [:vicamo][:vyang] from comment #6)
> Comment on attachment 738041 [details] [diff] [review]
> WIP v1
> 
> Review of attachment 738041 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Since that's etched in an open standard, let's do it :)

Yeah, I agree. Let's wait Anshul's information because the RIL binaries underneath are blocking the calls if we dial a number that's not in the [ro.]ril.ecclist lists.
So if the user doesn't have an ICC card, the numbers in the bug title are the *only* ones that can be dialed? In Brazil, 112 and 911 will redirect to the correct one, 190, but are not advertized anywhere, and although I don't have any data to back me up, are unknown to the very large majority of Brazilians.
Comment on attachment 738041 [details] [diff] [review]
WIP v1

Review of attachment 738041 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I read the document and that's slightly different. See comments below.

::: dom/system/gonk/ril_worker.js
@@ +52,5 @@
>  const PDU_HEX_OCTET_SIZE = 4;
>  
> +// See ETSI TS 122 101
> +const DEFAULT_EMERGENCY_NUMBERS = ["112", "911", "000", "08", "110", "999",
> +                                   "118", "119"];

This is okay.

@@ +2835,5 @@
> +       if (numbers.indexOf(number) == -1) {
> +         // [ro.]ril.ecclist system property found but the number is not on it,
> +         // so use our own list.
> +         numbers = DEFAULT_EMERGENCY_NUMBERS;
> +       }

This is not okay. According to same document, chapter 8 "Emergency Calls" `When a SIM/USIM containing stored emergency numbers is present, only those numbers are identified as emergency
numbers, i.e. default emergency numbers stored in the ME are ignored.`
Attachment #738041 - Flags: review+
Well, we will take care about ICC card present or absent. Thanks Vicamo.
(In reply to Vicamo Yang (@Telefonica 6F) [:vicamo][:vyang] from comment #10)
> This is not okay. According to same document, chapter 8 "Emergency Calls"
> `When a SIM/USIM containing stored emergency numbers is present, only those
> numbers are identified as emergency
> numbers, i.e. default emergency numbers stored in the ME are ignored.`

Vicamo, what version of that spec did you read? Is the correct one version 3GPP TS 22.101 V12.4.0 (2013-03)? Thanks!
Flags: needinfo?(vyang)
Attached patch WIP v2Splinter Review
This is a WIP in which I've tried to follow 22.101 V12.4.0 (2013-03) specs. We are still blocked on the issue commented in comment #4.
Attachment #738041 - Attachment is obsolete: true
Attachment #738041 - Flags: feedback?(anshulj)
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #12)
> Vicamo, what version of that spec did you read? Is the correct one version
> 3GPP TS 22.101 V12.4.0 (2013-03)? Thanks!

I think I got a pretty old one. :(
Flags: needinfo?(vyang)
libril that populates the ecc list.
If the sim card is present, then it will use values from the EF file.
If no sim card is present, then it will rely on hard-coded an NV items.
The libril will also block any emergency call that is not listed in ril.ecclist.

I did a few tests and found that with no sim card inserted, the ril.ecclist property already has all the numbers requested:
	[ril.ecclist]: [911,112,000,08,110,999,118,119]
I've also verified that the libril is letting these emergency numbers through and the call connects.


:jaeoo on what device are you seeing the ecclist being empty when no sim card is inserted?
(In reply to pgravel from comment #15)

Thanks for the information!

> :jaeoo on what device are you seeing the ecclist being empty when no sim
> card is inserted?

The devices is Ikura device (AU 019.083). I guess the same happened when the certification test were performed, the ecclist was empty.

I guess you don't need any detail about the build. If you need more info please let me know.
Same happening today:

BuildID 20130425151113
Firmware: V1.01.00.01.019.085

[ril.ecclist]: []
we will to check these emergency numbers.
I want to hightlight this is a OEM specific issue because I am testing with a different handset( Buri device with AU 19.088) and the list is:
[ril.ecclist]: [911,112,000,08,110,999,118,119]
Beatriz, we have concluded the same. Our customer engineering team is following up with the OEM.
Whiteboard: [PODB], Ikura
Whiteboard: [PODB], Ikura → [POVB], Ikura
Component: DOM: Device Interfaces → RIL
Product: Core → Boot2Gecko
Resolve this bug as it seemed worked for everybody. If not feel free to reopen it or file a new follow up bug.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: