860897 - Add locale to stub installer fallback url

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

The locale being installed by the stub installer can be different than the detected locale. I'll add a lang param to specify the locale being installed to the url when opening the fallback page to make this possible.

The webdev portion will be implemented in bug 860875

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

There has been discussion in bug 860875 that has led to additional requirements.

Comment 3

[Brian R. Bondy [:bbondy]]

Comment on attachment 741552 [details] [diff] [review]
patch rev2

Would it make sense to just specify 
https://www.mozilla.org/firefox/installer-help/?channel=beta&installer_lang=${AB_CD}

And that redirect to:
https://www.mozilla.org/${AB_CD}/firefox/installer-help/?channel=beta&installer_lang=${AB_CD}
?

Comment 4

[Chris More [:cmore]]

(In reply to Brian R. Bondy [:bbondy] from comment #3)
> Comment on attachment 741552 [details] [diff] [review]
> patch rev2
> 
> Would it make sense to just specify 
> https://www.mozilla.org/firefox/installer-help/
> ?channel=beta&installer_lang=${AB_CD}
> 
> And that redirect to:
> https://www.mozilla.org/${AB_CD}/firefox/installer-help/
> ?channel=beta&installer_lang=${AB_CD}
> ?

That may not be a bad option because what if someone was installing a language different from their default browser setting? The redirect without the locale at the start of the URL will detect their browser's locale, redirect, and keep the query parameters on the end. Probably 95% of the time, they will be the same value.

Comment 5

[Robert Strong (they/them - no direct email)]

(In reply to Chris More [:cmore] from comment #4)
> (In reply to Brian R. Bondy [:bbondy] from comment #3)
> > Comment on attachment 741552 [details] [diff] [review]
> > patch rev2
> > 
> > Would it make sense to just specify 
> > https://www.mozilla.org/firefox/installer-help/
> > ?channel=beta&installer_lang=${AB_CD}
> > 
> > And that redirect to:
> > https://www.mozilla.org/${AB_CD}/firefox/installer-help/
> > ?channel=beta&installer_lang=${AB_CD}
> > ?
> 
> That may not be a bad option because what if someone was installing a
> language different from their default browser setting? The redirect without
> the locale at the start of the URL will detect their browser's locale,
> redirect, and keep the query parameters on the end. Probably 95% of the
> time, they will be the same value.
I am fine with that but we need a call on what you would prefer soon since I will need to uplift this to the other channels. My only concern is whether the button will use the installer_lang param soonish since if the url is https://www.mozilla.org/${AB_CD}/... then at least the pages that are localized will get the correct localized installer even without a button that uses the installer_lang param. I can also remove the ${AB_CD}/ from https://www.mozilla.org/${AB_CD}/... at a future date if there is any worry about adding support so the button handles the installer_lang param in the near future.

Comment 6

[Robert Strong (they/them - no direct email)]

Going to land it as is... it can be revisited in a new bug if desired.

Comment 7

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5e60332f413

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c5e60332f413

Comment 9

[Robert Strong (they/them - no direct email)]

Comment on attachment 741552 [details] [diff] [review]
patch rev2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): stub installer implementation / bug 322206
User impact if declined: l10n stub installers won't offer l10n full installers on the fallback page (bug 860875)
Testing completed (on m-c, etc.): checked with the latest nightly build 
Risk to taking this patch (and alternatives if risky): minimal - uses existing functionality to open the url and this patch just changes the url used
String or IDL/UUID changes made by this patch: none

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 741552 [details] [diff] [review]
patch rev2

In support of l10n stub, approving. Also adding qawanted to verify that the English stub still functions correctly. We'll verify the localized stub before its launch.

Comment 11

[Robert Strong (they/them - no direct email)]

(In reply to Alex Keybl [:akeybl] from comment #10)
> Comment on attachment 741552 [details] [diff] [review]
> patch rev2
> 
> In support of l10n stub, approving. Also adding qawanted to verify that the
> English stub still functions correctly. We'll verify the localized stub
> before its launch.
For QA, the main thing you need to verify is that &installer_lang=AB_CD is present at the end of the url where AB_CD is the locale (e.g. en-US, fr, etc.). The full url will be
https://www.mozilla.org/AB_CD/firefox/installer-help/?channel=aurora&installer_lang=AB_CD

but the website will redirect based on whether the localized page is available. Also, bug 860875 is for the web page.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/53c2bba0fd35
https://hg.mozilla.org/releases/mozilla-beta/rev/742ad4f5a43d

Comment 13

[Cornel Ionce [:noni] [Hubs QA]]

For en-US beta build, the url looks like: http://www.mozilla.org/en-US/products/download.html?product=firefox-beta-stub&os=win&lang=en-US

Also, for the romanian and french versions: 
http://www.mozilla.org/ro/download/?product=firefox-21.0b3&os=win&lang=ro 
http://www.mozilla.org/fr/download/?product=firefox-21.0b3&os=win&lang=fr

The url doesn't look like the one from comment 11 but the language is present at the end of it. 
Can we mark this as verified?

Comment 14

[u279076]

Thanks Cornel, that's exactly what we are looking for. Note that the localized pages themselves won't be hooked up until bug 860875 is resolved.

When you get a chance, please verify the URLs for the Aurora and Nightly stub installers.

Comment 15

[Cornel Ionce [:noni] [Hubs QA]]

Verified for the FF 22 beta builds (en-US, fr, es)and also verified for the Aurora 23 stub installers (ro and fr).
The links look like: 
https://www.mozilla.org/en-US/firefox/installer-help/?channel=aurora&installer_lang=fr