86093 - Tab chars in html source show up as "[]" (square) in Error Console

Status: RESOLVED FIXED

(Core Graveyard :: Error Console, defect)

Description

[Henrik Gemal]

If you have a warning or error in a line in a html document that contains a tab 
chars, the tab chars get shown as [] in the JavaScript console. ala:

Warning: redeclaration of var i
Source File: http://dev.gemal.dk/gemal.dk/en/browserspy/profile.html
Line: 23, Column: 13
Source Code:
[][]for (var i = 0; i < fields.length; i++)


Will attach screenshot:

Expected:
Either tabs should be removed or replaced by 2 spaces

Comment 1

[Henrik Gemal]

Attachment: tab chars get shown as [] squares in console window

Comment 2

[sairuh (rarely reading bugmail)]

->hewitt

Comment 3

[Henrik Gemal]

\n chars are also shown as [] in the console.

Comment 4

[Henrik Gemal]

Attachment: patch to fix tabs and newlines

Comment 5

[Henrik Gemal]

Attachment: patch version 2

Comment 6

[Daniel Brooks [:db48x]]

Comment on attachment 77428 [details] [diff] [review]
patch version 2

>+            // get rid of newlines and tabs
>+            var sourcetext= aObject.sourceLine;

space before the =

>+            sourcetext = sourcetext.replace(/[\n|\r]/g, "");
>+            sourcetext = sourcetext.replace(/^\t*/g, "  ");
>+            sourcetext = sourcetext.replace(/\t/g, "  ");

I'd make it do this instead:
+	     sourcetext = sourcetext.replace(/\t/g, "  ");
+	     sourcetext = sourcetext.replace(/^\s*/, "");

and then change mozilla/xpfe/components/console/resources/content/console.css
so that the rule for .console-error-source has a margin-left to accomplish the
indentation

then it'll be r=db48x

Comment 7

[Henrik Gemal]

Attachment: better patch. now using a style

Comment 8

[Henrik Gemal]

alecf: could you sr?

Comment 9

[[e-mail]]

Erm... if you fiddle about with tabs like that you'll kill the error marker :-(

Why not row.setAttribute("code", aObject.sourceLine.replace(/[\x00-\x1F]/g, " "));

[Aside: what was a dynamic regexp doing there?]

Comment 10

[Alec Flett]

let me know when this is sorted out. I'm not sure I agree with the replacement
of all characters < 0x1F though.

I don't know what tabs should be. I was going to suggest 8 spaces, myself :)

Comment 11

[Daniel Brooks [:db48x]]

the error marker isn't usually correct anyway, as both the code and the marker
are shown in a varible width font, so even if we know what character the error
was on, we can't line it up right. 

I say go ahead and check this patch in, and file the marker misalignment as a
seperate bug. (I'd also change it to display an <hr/> or just a border instead
of a bunch of dashes, so it would look prettier. That and the marker should
probably be indented the same was as the code so that it has a better chance of
lining up correctly.) 

Comment 12

[[e-mail]]

Actually the marker works fine in Classic, there's already a bug filed on that.

Comment 13

[Simon Bünzli]

Attachment: replace all whitespace characters with spaces

This patch simply replaces all whitespace characters which should prevent most of these irritating/useless squares (haven't seen any of them for over a year). The reason to replace every character with precisely one space is that otherwise the column marker will point to the wrong location since the column count is in plain characters.

Comment 14

[Nickolay_Ponomarev]

mozilla/toolkit/components/console/content/consoleBindings.xml         1.17
mozilla/xpfe/components/console/resources/content/consoleBindings.xml  1.29