If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Consolidate "perform a build" logic outside of mach

NEW
Unassigned

Status

()

Core
Build Config
5 years ago
5 years ago

People

(Reporter: gps, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mach])

(Reporter)

Description

5 years ago
|mach build| currently contains a lot of code for performing builds. Due to the way it is implemented, it is outside the build system proper. This means features like compiler warning aggregation and Finder-is-slowing-down-your-build are only active when building through mach.

It was always my intent to have as little "business logic" in mach commands as possible. IMO a mach command method should simply instantiate a thing, call that thing, and format its output.

In this bug, I'm proposing moving the "build the tree" logic outside of mach_commands.py and into somewhere in mozbuild.*.

Once we've done that, we can modify client.mk to call that code instead of make directly. This will give us compiler warning detection and future features on the official builders. Yay!
You need to log in before you can comment on or make changes to this bug.