860970 - Need to sync new security prefs from bug 842191

Status: RESOLVED FIXED

(SeaMonkey :: Security, defect)

Description

[[e-mail]]

Bug 842191 added four preferences to pref-ssl.xul but didn't sync them.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Philip Chee]

Neil don't you think we should also do this: http://hg.mozilla.org/mozilla-central/rev/60b08f643863

> 1.12 +// Block insecure active content on https pages
> 1.13 +pref("security.mixed_content.block_active_content", true);

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 736541 [details] [diff] [review]
Proposed patch

Review of attachment 736541 [details] [diff] [review]:
-----------------------------------------------------------------

Please sort the prefs.

::: suite/browser/browser-prefs.js
@@ +930,5 @@
>  pref("services.sync.prefs.sync.security.warn_submit_insecure", true);
>  pref("services.sync.prefs.sync.security.warn_viewing_mixed", true);
> +pref("services.sync.prefs.sync.security.warn_mixed_active_content", true);
> +pref("services.sync.prefs.sync.security.mixed_content.block_active_content", true);
> +pref("services.sync.prefs.sync.security.warn_mixed_display_content", false);

What's the point of adding a pref that should not be synced?

Comment 4

[[e-mail]]

(In reply to Philip Chee from comment #2)
> > 1.12 +// Block insecure active content on https pages
> > 1.13 +pref("security.mixed_content.block_active_content", true);
Sure, but in a separate bug.

(In reply to Jens Hatlak from comment #3)
> (From update of attachment 736541 [details] [diff] [review])
> Please sort the prefs.
Sorry, I hadn't noticed.

> > +pref("services.sync.prefs.sync.security.warn_mixed_display_content", false);
> What's the point of adding a pref that should not be synced?
Oops, too much copy & paste.

Comment 5

[[e-mail]]

Attachment: Addressed review comments

Comment 6

[[e-mail]]

Pushed comm-central changeset aadbe43b0aa3.

Comment 7

[[e-mail]]

Comment on attachment 736697 [details] [diff] [review]
Addressed review comments

[Approval Request Comment]
Regression caused by (bug #): (New preferences - 842191)
User impact if declined: Some SSL preferences don't sync
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None

Comment 8

[[e-mail]]

One of these days I'll get these flags right first time...

Comment 9

[Jens Hatlak (:InvisibleSmiley)]

(In reply to [e-mail] from comment #8)
> One of these days I'll get these flags right first time...

Actually you don't need to set flags for the version that matches the TM. ;-)

Comment 10

[[e-mail]]

https://hg.mozilla.org/releases/comm-aurora/rev/a7d94d98f708