861062 - getTextAfterOffset for word boundaries: still evolving

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Note, that tricky offset == 0 part is used for (https://developer.gnome.org/atk/stable/AtkText.html#atk-text-get-text-after-offset):

" The returned string will contain the word after the offset if the offset is inside a word and will contain the word after the word after the offset if the offset is not inside a word. "

however reading the spec from beginning we allowed for a different thing

" If the boundary_type is ATK_TEXT_BOUNDARY_WORD_END the returned string is from the word end at or after the offset to the next work end. "

since 0 is special offset and it's treated as word start and word end the same time

Comment 2

[alexander :surkov (:asurkov)]

Trev, ping

Comment 3

[Trevor Saunders (:tbsaunde)]

Comment on attachment 736653 [details] [diff] [review]
patch

>+    case BOUNDARY_WORD_END:
>+      // If the offset is a word end (expect 0 offset) then move forward to find

s/expect/except/

Comment 4

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/684e6c3a9c3c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/684e6c3a9c3c