Closed Bug 861062 Opened 9 years ago Closed 9 years ago

getTextAfterOffset for word boundaries: still evolving

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
Note, that tricky offset == 0 part is used for (https://developer.gnome.org/atk/stable/AtkText.html#atk-text-get-text-after-offset):

" The returned string will contain the word after the offset if the offset is inside a word and will contain the word after the word after the offset if the offset is not inside a word. "

however reading the spec from beginning we allowed for a different thing

" If the boundary_type is ATK_TEXT_BOUNDARY_WORD_END the returned string is from the word end at or after the offset to the next work end. "

since 0 is special offset and it's treated as word start and word end the same time
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #736653 - Flags: review?(trev.saunders)
Trev, ping
Attachment #736653 - Flags: review?(trev.saunders) → review+
Comment on attachment 736653 [details] [diff] [review]
patch

>+    case BOUNDARY_WORD_END:
>+      // If the offset is a word end (expect 0 offset) then move forward to find

s/expect/except/
https://hg.mozilla.org/mozilla-central/rev/684e6c3a9c3c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.