861081 - [Gaia][Settings] Use new WebAPI to access SIM lock functionality

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Edgar Chen [:edgar] (PTO until 02/09)]

In bug 860585, we are going to move cardLock related API from mozMobileConnection to mozIccManager. This bug is filed in Gaia side to make corresponding changes.

Comment 1

[Edgar Chen [:edgar] (PTO until 02/09)]

working branch:
https://github.com/EdgarChen/gaia/commits/bug_861081

Comment 2

[Edgar Chen [:edgar] (PTO until 02/09)]

Attachment: gaia pull request #10361

Comment 3

[Edgar Chen [:edgar] (PTO until 02/09)]

Comment on attachment 761903 [details]
gaia pull request #10361

bug 860585 is already r+ and sr+. I would like to request review for Gaia changes first. I plan to merge patches of gecko and gaia at the same time after all got r+. :fcampo, could you help to review? Thanks in advance.

Comment 4

[Fernando Campo (:fcampo)]

Comment on attachment 761903 [details]
gaia pull request #10361

Looks cool to me. Just a small aesthetic nit added on a comment.

Before merging remember to squash the commits and r=me


Thanks!

Comment 5

[Edgar Chen [:edgar] (PTO until 02/09)]

Hi :fcampo, bug 860585 is already landed in m-c, could you help to merge this patch? Thank

Comment 6

[Fernando Campo (:fcampo)]

(In reply to Edgar Chen [:edgar][:echen] from comment #5)
> Hi :fcampo, bug 860585 is already landed in m-c, could you help to merge
> this patch? Thank
Comment on github

Comment 7

[Fernando Campo (:fcampo)]

Merged https://github.com/mozilla-b2g/gaia/commit/34734aedea7b2759ff5f0592eada51b4ecbd4bb0

Thanks for your work Edgar

Comment 8

[Fernando Campo (:fcampo)]

Please modify the flags accordingly for the versions affected by the changes, if any. Guess it depends on which version of gecko is affected by the new API

Comment 9

[Edgar Chen [:edgar] (PTO until 02/09)]

The changes of gecko is only happened in m-c. Thanks

Comment 10

[Julien Wajsberg [:julienw]]

If I understand correctly, this breaks the previously working (but unsupported) setup of gaia master on gecko b2g18, which lots of us developers have been using, am I right ?