When in customization mode, widgets aren't re-wrapped when dragging to the same position in an area

RESOLVED FIXED in Firefox 28

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Unfocused, Assigned: Unfocused)

Tracking

unspecified
Firefox 28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Noticed this when clicking randomly. Very scientific.

When in customization mode, start dragging a widget from the panel, but then drag it back to its original position and drop it there. It'll become unwrapped, so becomes a normal toolbaritem you can interact with - instead of a toolbarpaletteitem.
Oh hey, just noticed the exception:

Error: TypeError: toolbarItem is null
Source File: resource:///modules/CustomizeMode.jsm
Line: 358

And then when attempting to drag it again:

Error: TypeError: item is null
Source File: resource:///modules/CustomizeMode.jsm
Line: 466
Latest code is throwing the following exception instead:

Error: TypeError: aNode is null
Source File: resource:///modules/CustomizeMode.jsm
Line: 307
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Created attachment 737310 [details] [diff] [review]
Patch v1
Attachment #737310 - Flags: review?(jaws)
Attachment #737310 - Flags: review?(jaws) → review+
https://hg.mozilla.org/projects/jamun/rev/6ece41102353
OS: Windows 8 → All
Hardware: x86_64 → All
Whiteboard: [fixed in jamun]
Whiteboard: [fixed in jamun] → [fixed in jamun][fixed-in-ux]

Comment 6

4 years ago
https://hg.mozilla.org/mozilla-central/rev/c124fa289248
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in jamun][fixed-in-ux]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.