Closed Bug 861092 Opened 13 years ago Closed 12 years ago

When in customization mode, widgets aren't re-wrapped when dragging to the same position in an area

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 28

People

(Reporter: Unfocused, Assigned: Unfocused)

References

Details

Attachments

(1 file)

Patch v1
1.33 KB, patch
jaws
: review+
Details | Diff | Splinter Review
Noticed this when clicking randomly. Very scientific. When in customization mode, start dragging a widget from the panel, but then drag it back to its original position and drop it there. It'll become unwrapped, so becomes a normal toolbaritem you can interact with - instead of a toolbarpaletteitem.
Oh hey, just noticed the exception: Error: TypeError: toolbarItem is null Source File: resource:///modules/CustomizeMode.jsm Line: 358 And then when attempting to drag it again: Error: TypeError: item is null Source File: resource:///modules/CustomizeMode.jsm Line: 466
Latest code is throwing the following exception instead: Error: TypeError: aNode is null Source File: resource:///modules/CustomizeMode.jsm Line: 307
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Attached patch Patch v1 — — Splinter Review
Attachment #737310 - Flags: review?(jaws)
Attachment #737310 - Flags: review?(jaws) → review+
https://hg.mozilla.org/projects/jamun/rev/6ece41102353
OS: Windows 8 → All
Hardware: x86_64 → All
Whiteboard: [fixed in jamun]
Whiteboard: [fixed in jamun] → [fixed in jamun][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/c124fa289248
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in jamun][fixed-in-ux]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: