861092 - When in customization mode, widgets aren't re-wrapped when dragging to the same position in an area

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Noticed this when clicking randomly. Very scientific.

When in customization mode, start dragging a widget from the panel, but then drag it back to its original position and drop it there. It'll become unwrapped, so becomes a normal toolbaritem you can interact with - instead of a toolbarpaletteitem.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Oh hey, just noticed the exception:

Error: TypeError: toolbarItem is null
Source File: resource:///modules/CustomizeMode.jsm
Line: 358

And then when attempting to drag it again:

Error: TypeError: item is null
Source File: resource:///modules/CustomizeMode.jsm
Line: 466

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Latest code is throwing the following exception instead:

Error: TypeError: aNode is null
Source File: resource:///modules/CustomizeMode.jsm
Line: 307

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/projects/jamun/rev/6ece41102353

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Landed in UX as https://hg.mozilla.org/projects/ux/rev/c124fa289248

Comment 6

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/c124fa289248