Closed Bug 861138 Opened 7 years ago Closed 7 years ago

Landscape toolbar should use same layout as portrait toolbar

Categories

(Firefox for Android :: Theme and Visual Design, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 23
Tracking Status
firefox23 --- verified

People

(Reporter: pretzer, Assigned: sriram)

Details

Attachments

(1 file)

Now that we have the dynamic toolbar I think the landscape toolbar could share the same layout (height, etc.) with the toolbar in portrait mode. Saving vertical space is not really necessary anymore with the toolbar automatically hiding away and I imagine this could save a lot of duplicate resources and reduce code complexity. Is there any reason not to do this?
For the record: Chrome and Stock Browser do share the same toolbar in both modes as well.
CC'ing Ian and Sriram: Can you give UX/Dev feedback on this proposal?
(In reply to Peter Retzer (:pretzer) from comment #0)
> Now that we have the dynamic toolbar I think the landscape toolbar could
> share the same layout (height, etc.) with the toolbar in portrait mode.
> Saving vertical space is not really necessary anymore with the toolbar
> automatically hiding away and I imagine this could save a lot of duplicate
> resources and reduce code complexity. Is there any reason not to do this?
> For the record: Chrome and Stock Browser do share the same toolbar in both
> modes as well.

I agree that Chrome's is the same size. We wanted to follow general Android apps' conventions and used standard Android recommended sizes for portrait and landscape on phones. Bug 858687 would take care of reducing the resources (browser_toolbar.xml) to just one file :D
That said, I still open to having same size in both orientations. This would reduce the resources we use.
(In reply to Sriram Ramasubramanian [:sriram] from comment #2)
> (In reply to Peter Retzer (:pretzer) from comment #0)
> > Now that we have the dynamic toolbar I think the landscape toolbar could
> > share the same layout (height, etc.) with the toolbar in portrait mode.
> > Saving vertical space is not really necessary anymore with the toolbar
> > automatically hiding away and I imagine this could save a lot of duplicate
> > resources and reduce code complexity. Is there any reason not to do this?
> > For the record: Chrome and Stock Browser do share the same toolbar in both
> > modes as well.
> 
> I agree that Chrome's is the same size. We wanted to follow general Android
> apps' conventions and used standard Android recommended sizes for portrait
> and landscape on phones. Bug 858687 would take care of reducing the
> resources (browser_toolbar.xml) to just one file :D
> That said, I still open to having same size in both orientations. This would
> reduce the resources we use.

Fine by me.
Assignee: nobody → lala.pashayan
Assignee: lala.pashayan → sriram
Attached patch PatchSplinter Review
This makes the BrowserToolbar to be 48dp on both orientations. We don't use a lot of resources it seems! :O :O
Attachment #738737 - Flags: review?(mark.finkle)
Attachment #738737 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/0921c42708f2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.