861138 - Landscape toolbar should use same layout as portrait toolbar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Peter Retzer (:pretzer)]

Now that we have the dynamic toolbar I think the landscape toolbar could share the same layout (height, etc.) with the toolbar in portrait mode. Saving vertical space is not really necessary anymore with the toolbar automatically hiding away and I imagine this could save a lot of duplicate resources and reduce code complexity. Is there any reason not to do this?
For the record: Chrome and Stock Browser do share the same toolbar in both modes as well.

Comment 1

[Peter Retzer (:pretzer)]

CC'ing Ian and Sriram: Can you give UX/Dev feedback on this proposal?

Comment 2

[Sriram Ramasubramanian [:sriram]]

(In reply to Peter Retzer (:pretzer) from comment #0)
> Now that we have the dynamic toolbar I think the landscape toolbar could
> share the same layout (height, etc.) with the toolbar in portrait mode.
> Saving vertical space is not really necessary anymore with the toolbar
> automatically hiding away and I imagine this could save a lot of duplicate
> resources and reduce code complexity. Is there any reason not to do this?
> For the record: Chrome and Stock Browser do share the same toolbar in both
> modes as well.

I agree that Chrome's is the same size. We wanted to follow general Android apps' conventions and used standard Android recommended sizes for portrait and landscape on phones. Bug 858687 would take care of reducing the resources (browser_toolbar.xml) to just one file :D
That said, I still open to having same size in both orientations. This would reduce the resources we use.

Comment 3

[Ian Barlow (:ibarlow)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #2)
> (In reply to Peter Retzer (:pretzer) from comment #0)
> > Now that we have the dynamic toolbar I think the landscape toolbar could
> > share the same layout (height, etc.) with the toolbar in portrait mode.
> > Saving vertical space is not really necessary anymore with the toolbar
> > automatically hiding away and I imagine this could save a lot of duplicate
> > resources and reduce code complexity. Is there any reason not to do this?
> > For the record: Chrome and Stock Browser do share the same toolbar in both
> > modes as well.
> 
> I agree that Chrome's is the same size. We wanted to follow general Android
> apps' conventions and used standard Android recommended sizes for portrait
> and landscape on phones. Bug 858687 would take care of reducing the
> resources (browser_toolbar.xml) to just one file :D
> That said, I still open to having same size in both orientations. This would
> reduce the resources we use.

Fine by me.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This makes the BrowserToolbar to be 48dp on both orientations. We don't use a lot of resources it seems! :O :O

Comment 5

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/0921c42708f2

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0921c42708f2