Closed Bug 861146 Opened 10 years ago Closed 10 years ago

Provide pthread_rwlock replacement for Android 2.2

Categories

(Core :: WebRTC, defect)

Product:
Core
Component:
WebRTC
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla23

People

(Reporter: gcp, Assigned: gcp)

References

Details

(Whiteboard: [WebRTC][blocking-webrtc-][android-webrtc+][qa-])

Attachments

(1 file)

Patch 1. Use generic rwlock implementation
2.22 KB, patch
jesup
: review+
Details | Diff | Splinter Review 
Bug 850713 bumped our Android NDK platform to android-9, but we still support Android 2.2 (android-8) devices, so any functions that are not in there will cause Fennec to crash.

Currently this is at least true for pthread_rwlock_*:

04-12 15:16:57.483 E/GeckoLinker(21708): /data/app/org.mozilla.fennec-1.apk!/libxul.so: Error: relocation to NULL @0x017aae84 for symbol "pthread_rwlock_unlock"
Blocks: 850713
Blocks: 835716
Whiteboard: [WebRTC][blocking-webrtc-][android-webrtc+]
Seems like some stuff was added to the 3.20 WebRTC release that makes this super-easy (or I missed it last time).
Attachment #736931 - Flags: review?(rjesup)
Attachment #736931 - Flags: review?(rjesup) → review+
https://hg.mozilla.org/mozilla-central/rev/15553a58337e
Assignee: nobody → gpascutto
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Whiteboard: [WebRTC][blocking-webrtc-][android-webrtc+] → [WebRTC][blocking-webrtc-][android-webrtc+][qa-]
You need to log in before you can comment on or make changes to this bug.