86116 - Auto-spellcheck doesn't work all the time, Win and Linux

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P2)

Description

[esther]

Using build 2001-06-13 on win, mac and linux the preference for Auto-spellcheck
on Send doesn't auto-spell check on all send msgs if there are multiple Compose
windows opened.  This appears to be only Linux and Window, will test mac more to
see if it happens with a different scenario.  

1. Launch app (make sure Message Compose preference for "check spelling before
sending" is checked. 
2. Launch mail
3. Click on New Msg and compose a msg to yourself (for keeping track put #1 in
subject) add text to the body.  (don't send it)
4. Click on New Msg button from 3-pane window again and compose a message to
yourself putting #2 in the subject, add text to the  body.
5. Go to Msg #1 and Send, when spell check dialog comes up click Close)  Msg is sent
6. Go to Msg #2 and Send, Spell check dialog doesn't come up.

If you add a 3rd msg and send in order 1, 2 &3 the 3rd one doesn't auto
spellcheck.  
If you send reversing the order 3, then 2, then 1 it spell checks all 3

Result: some sent messages don't autospell check
Expected:  all sent messages auto spellcheck

Comment 1

[esther]

Another scenario where automatic spell check doesn't work on all platforms, not
sure if it's related to this bug. 
If focus is in the subject or addressing widget when you click Send the
auto-spellchecker does not come up.

Comment 2

[esther]

nominating as nsbeta1, if the user is a really bad speller and absolutely wants
all msgs spell checked before sending (known because they selected this option)
then this is bad that is spell checks sometimes but not always.  

Comment 3

[scottputterman]

moving to 0.9.3

Comment 4

[Jaime Rodriguez, Jr.]

I'd like to nominate this one for nsCatFood. Hopefully, we can pick this one up
in limbo land . . . </8^(

Comment 5

[varada]

I am unable to reproduce this using Win 2001062204 or with 06/25/2001 Debug Build.
Are we still seeing this?

Comment 6

[Jaime Rodriguez, Jr.]

Yup! Saw it again today on the 2001062503.

Comment 7

[Jean-Francois Ducarroz]

Varada, I thought you get a fix for that yesterday!

Comment 8

[varada]

My comment was before I started working on the fix. I was able to reproduce the
problem and have the fix on hand. reassigning bug to self

Comment 9

[varada]

Attachment: Patch V 1.0

Comment 10

[Jean-Francois Ducarroz]

R=ducarroz

Comment 11

[(not reading, please use [e-mail] instead)]

1)  what's going on?

why does this fail?   is the command not enabled?  (are there other commands
that are failing for the same reason?)

I don't think this work around belongs on the trunk until we figure that out.

2)  for nsBranch (a work around would be acceptable there)  
 
you've just copied code from ComposerCommands.js

for your branch only work around, can you do this:

nsSpellingCommand.doCommand(foo);

instead of duplicating the code.

Comment 12

[varada]

We couldnt find a reason as to why it doesnt work - we tried and played with
focus and other stuff to see what was causing it. Simon Fraser suggested that
the easiest way around would be to implement the calling of this spell check
window ourselves even if it involved duplicating some code. I shall try the
nsSpellingCommand.doCommand(foo); and see if that works. I agree with you that
this should probably not go into the trunk since it is merely a workaround and
not a solution.

Comment 13

[varada]

Attachment: Patch V 1.2 with nsSpellingCommand.doCommand("cmd_spelling")

Comment 14

[(not reading, please use [e-mail] instead)]

sr=sspitzer on the last work around for the nsBranch.

don't check that into the trunk, see if you can figure out what's really going on. 

(there might be other commands with the same problem.)

Comment 15

[scottputterman]

moving to 0.9.4

Comment 16

[Scott MacGregor]

Mail news triage meeting --> .9.5

however, this means we may want to check the patch that went into the branch
into the .9.4 branch for eMojo so eMojo's behavior doesn't regress.

Comment 17

[scottputterman]

moving to 0.9.6

Comment 18

[scottputterman]

moving to 0.9.7

Comment 19

[varada]

Attachment: Patch V.3

We disable the spellcheck when the focus is on the subject line, attachment
pane, identity or addressing widget. This prevents it from being invoked when
the focus is on them during send. A workaround is to check for the spellcheck
pref and then before invoking it we switch focus to the body and thus enable
spellcheck.

Comment 20

[Jean-Francois Ducarroz]

Comment on attachment 70191 [details] [diff] [review]
Patch V.3

right, in order the command to be dispatched to the editor, we need to set the
focus in editor. R=ducarroz

Comment 21

[Scott MacGregor]

Comment on attachment 70191 [details] [diff] [review]
Patch V.3

sr=mscott.

Comment 22

[varada]

Marking Fixed.

Comment 23

[esther]

Using 20020307 on winxp, 20020307 on linux and 20020304 on mac 9.1 this is
fixed. Verified