861209 - Refactor tests where applicable with consistent use of double-quotes

Status: RESOLVED WONTFIX

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Jonathan French (:jfrench)]

Begat from Henrik's comments in bug 848649, where I was in some cases 'reusing' legacy code for paths which had used single quotes - we'd like to have consistent application of double quotes for all paths for all tests, across the repo.

::: tests/functional/testSecurity/testGreyLarry.js
@@ +6,5 @@
>  var { assert, expect } = require("../../../lib/assertions");
>  var utils = require("../../../lib/utils");
>  
> +const BASE_URL = collector.addHttpResource("../../../data/");
> +const TEST_URL = BASE_URL + 'layout/mozilla.html';
>
> Can you file a follow-up bug re consistency for double and single quotes? 
> We shouldn't mix them.

This bug represents that future work.

Comment 1

[Jonathan French (:jfrench)]

I haven't had time to look at this bug so unassigning myself for now, in case someone else wants to take it. Or maybe we just close the bug, acknowledging that as the code evolves, the correct quoting usage will be enforced during code reviews. The code will just eventually transition to the desired state.

Comment 2

[Jonathan French (:jfrench)]

I'm inclined to mark this wontfix in the context of an eventual migration to marionette, and ongoing best practices anyway. Less bugs equals less triage of old bugs :) If anyone disagrees feel free to reopen.