Closed
Bug 861217
Opened 12 years ago
Closed 12 years ago
add tests for scrollWidth on a table data TD cell in a fixed-layout table
Categories
(Core :: DOM: CSS Object Model, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: dtrebbien, Assigned: dtrebbien)
References
Details
(Whiteboard: [mentor=bz][lang=js])
Attachments
(1 file, 2 obsolete files)
|
7.15 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
When the width of a TD is restricted in a fixed-layout table (table-layout:fixed), the TD's reported scrollWidth may be incorrect.
Please see the attached test case. I have tested Firefox 20.0, Firefox ESR 17.0.5, and Firefox 12.0 and found that the scrollWidth of `theTD' is 98. In Firefox Beta 21.0, Firefox Aurora 22.0a2 (2013-04-12), Chrome 26.0.1410.65, Safari 6.0.3, and IE 9, the scrollWidth is correct, ~293.
I used mozregression and found:
Last bad nightly (contains this issue): 2013-01-29
First good nightly (fixed): 2013-01-30
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0c45e6378f1f&tochange=677e87c11252
This range includes the patch for Bug 833542, and I think that the 833542 patch also fixed this bug.
|
||
Comment 1•12 years ago
|
||
So I'm confused. If this is fixed... what's this bug about, exactly?
|
|
||
Updated•12 years ago
|
Flags: needinfo?(dtrebbien)
|
Assignee | |
Comment 2•12 years ago
|
||
This is fixed, yes. I wasn't sure if another test case should be created specifically for this bug given that the 833542 patch seems to have fixed this bug unintentionally.
Flags: needinfo?(dtrebbien)
|
|
||
Comment 3•12 years ago
|
||
Ah, I see.
Depends on: 833542
Summary: scrollWidth incorrect on a table data TD cell in a fixed-layout table → add tests for scrollWidth on a table data TD cell in a fixed-layout table
|
|
||
Updated•12 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [mentor=bz]
|
||
Updated•12 years ago
|
Severity: critical → normal
Whiteboard: [mentor=bz] → [mentor=bz][lang=js]
|
|
Assignee | |
Updated•12 years ago
|
Attachment #736840 -
Attachment mime type: text/plain → text/html
|
|
Assignee | |
Comment 4•12 years ago
|
||
Attached is my proposed Mochitest test file. When I run the test file in a build of Firefox @ 129356:4420f27742c7, I get the following result:
Passed: 32
Failed: 0
Todo: 0
Attachment #736840 -
Attachment is obsolete: true
|
|
||
Comment 5•12 years ago
|
||
Daniel, would you mind attaching that in diff form?
|
|
Assignee | |
Comment 6•12 years ago
|
||
Attachment #740089 -
Attachment is obsolete: true
|
|
||
Comment 7•12 years ago
|
||
Comment on attachment 740755 [details] [diff] [review]
Patch
Yeah, much better. ;) Now you just want to request review. But since I'm here anyway, r=me, and thank you!
Attachment #740755 -
Flags: review+
|
|
||
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 8•12 years ago
|
||
|
|
Assignee | |
Comment 9•12 years ago
|
||
Awesome! Thank you!
I guess this can be marked "FIXED"?
|
|
||
Comment 10•12 years ago
|
||
It will be once it's merged over to mozilla-central.
|
|
||
Comment 11•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•