Closed Bug 861229 Opened 11 years ago Closed 11 years ago

Add in a filter header

Categories

(Marketplace Graveyard :: API, defect, P3)

Product:
Marketplace Graveyard
Component:
API
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2013-04-25

People

(Reporter: andy+bugzilla, Assigned: chuck)

Details

(Whiteboard: p=2) 

We filter based on region, carrier, device and who knows what else. I think it would be nice if we put these filters into a header. Something like:

X-API-Filters: device=tablet,mobile&region=US etc... (lets make this a urlencode list)

For example a request to /api/v1/apps/app/123/ will return a different value, maybe a 404 or a 403 or a 451 (bug 860993), without any explanation. This will help us debug the result and let API consumers figure out why.
Lang as well. Note: these are implicit values we look up, rather than filters in the query string. Hopefully those ones are obvious.
Priority: -- → P3
Whiteboard: p=1
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → 2013-04-25
If there's a filter header, we need to make sure a corresponding entry in the Vary header must also be set.
Landed: https://github.com/mozilla/zamboni/commit/e147518321ee63e410cf3305f0a39742fdb3836c
Assignee: nobody → charmston
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: p=1 → p=2
You need to log in before you can comment on or make changes to this bug.