861269 - GC: Continuing the rooting of XPConnect

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Comment 1

[Jon Coppeard (:jonco)]

Attachment: 1 - Change arguments from foo_ to fooArg style

Comment 2

[Jon Coppeard (:jonco)]

Attachment: 2 - Make AutoPropertyDescriptorRooter public

This is needed for rooting XrayWrapper.cpp

Comment 3

[Jon Coppeard (:jonco)]

Attachment: 3 - Rooting in XrayWrapper.cpp

Comment 4

[Jon Coppeard (:jonco)]

Attachment: 4 - Rooting in nsXPConnect.cpp

Comment 5

[Jon Coppeard (:jonco)]

Attachment: 5 - Rooting in XPCJSID.cpp

Comment 6

[Terrence Cole [:terrence]]

Comment on attachment 736875 [details] [diff] [review]
2 - Make AutoPropertyDescriptorRooter public

Review of attachment 736875 [details] [diff] [review]:
-----------------------------------------------------------------

I'd prefer to get bug 860572 polished up and landed to handle this case. I'll work on that more today.

Comment 7

[Jon Coppeard (:jonco)]

I'm landing parts 1, 4 and 5 as they are ready now, and will continue the work on XrayWrapper in a separate bug.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f0c70f3f73ef
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4fe6ac7475b
https://hg.mozilla.org/integration/mozilla-inbound/rev/605d892d2e51

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f0c70f3f73ef
https://hg.mozilla.org/mozilla-central/rev/a4fe6ac7475b
https://hg.mozilla.org/mozilla-central/rev/605d892d2e51