861271 - [mozfile] Add support for very long paths and add tests

Status: REOPENED

(Testing :: Mozbase, defect, P5)

Description

[Jeff Hammel]

bug 860426 adds additional functionality to deal with long paths on
windows:

http://hg.mozilla.org/build/tools/file/1c40178a3527/clobberer/clobberer.py#l42

This functionality should be ported to mozfile and a test written to
ensure that it is not hit.

Comment 1

[bitsjamadagni]

Sir ,
   Can we use the stat module and check for the readability
 # Make sure directory is writable
     SetFileAttributesW('\\\\?\\' + dir, FILE_ATTRIBUTE_NORMAL)
can we use this instead 
     fileAtt = os.stat(dir)[0]
     if (not fileAtt & stat.S_IWRITE):
         os.chmod(myFile, stat.S_IWRITE)

Thanks.

Comment 2

[bitsjamadagni]

(In reply to bitsjamadagni from comment #1)
> Sir ,
>    Can we use the stat module and check for the readability
>  # Make sure directory is writable
>      SetFileAttributesW('\\\\?\\' + dir, FILE_ATTRIBUTE_NORMAL)
> can we use this instead 
>      fileAtt = os.stat(dir)[0]
>      if (not fileAtt & stat.S_IWRITE):
>          os.chmod(dir, stat.S_IWRITE)
> 
> Thanks.

Comment 3

[Jeff Hammel]

I don't know if i can answer that question correctly.  The short answer is "we should do the right thing that works". if os.stat is that, then sure

Comment 4

[Andrew Halberstadt [:ahal]]

>         os.chmod(dir, stat.S_IWRITE)

This should be 'os.chmod(dir, fileAtt | stat.S_IWRITE)' otherwise the other permissions would be overwritten.

Comment 5

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Mass closing bugs with no activity in 2+ years. If this bug is important to you, please re-open.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We might want to check if we can handle those paths.