Closed
Bug 861304
Opened 11 years ago
Closed 11 years ago
Environment variable deletion shouldn't fail in strict mode code (and should return true in non-strict code)
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Waldo, Assigned: Waldo)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.42 KB,
patch
|
irakli
:
review+
|
Details | Diff | Splinter Review |
See bug 858677 comment 4. It looks to me like https://hg.mozilla.org/projects/addon-sdk/ is the canonical development location, with, um, some vague connection to development on github. I have no idea whether I should be jumping through github hoops or posting a Mercurial patch here. Hopefully just posting a patch for review here the good old-fashioned Mozilla way will get the job done.
Attachment #736894 -
Flags: review?(rFobic)
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #736894 -
Attachment is obsolete: true
Attachment #736894 -
Flags: review?(rFobic)
Attachment #736897 -
Flags: review?(rFobic)
|
||
Updated•11 years ago
|
Attachment #736897 -
Flags: review?(rFobic) → review+
|
||
Comment 2•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/566553d48ed310bc11e8e278240a9ee2803993d5 Merge pull request #937 from Gozala/bug/env@861304 fix Bug 861304 - Environment variable deletion shouldn't fail in strict mode code r=@gozala
|
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Comment 3•11 years ago
|
||
Thanks Jeff for the fix, we mainly operate on github and use pull request, but plain old patches on bugzilla work just fine too.
You need to log in
before you can comment on or make changes to this bug.
Description
•