861314 - about:config -> Add a New Setting crashes (2.2 only?)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Geoff Brown [:gbrown]]

With today's nightly, if I go to about:config and click "Add a New Setting", Firefox crashes. :sriram seems to know the cause and suspects this only happens on 2.2 devices (my device is 2.2).

Logcat shows:

    E/GeckoAppShell(10496): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
    E/GeckoAppShell(10496): android.view.InflateException: Binary XML file line #20: Error inflating class <unknown>
    E/GeckoAppShell(10496):         at android.view.LayoutInflater.createView(LayoutInflater.java:513)
    E/GeckoAppShell(10496):         at com.android.internal.policy.impl.PhoneLayoutInflater.onCreateView(PhoneLayoutInflater.java:56)
    E/GeckoAppShell(10496):         at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:563)
    E/GeckoAppShell(10496):         at android.view.LayoutInflater.inflate(LayoutInflater.java:385)
    E/GeckoAppShell(10496):         at android.view.LayoutInflater.inflate(LayoutInflater.java:320)
    E/GeckoAppShell(10496):         at android.widget.ArrayAdapter.createViewFromResource(ArrayAdapter.java:332)
    E/GeckoAppShell(10496):         at android.widget.ArrayAdapter.getView(ArrayAdapter.java:323)
    E/GeckoAppShell(10496):         at android.widget.AbsSpinner.onMeasure(AbsSpinner.java:192)
    E/GeckoAppShell(10496):         at android.view.View.measure(View.java:8224)
    E/GeckoAppShell(10496):         at android.widget.ScrollView.measureChildWithMargins(ScrollView.java:989)
    E/GeckoAppShell(10496):         at android.widget.FrameLayout.onMeasure(FrameLayout.java:245)
    E/GeckoAppShell(10496):         at android.widget.ScrollView.onMeasure(ScrollView.java:286)
    E/GeckoAppShell(10496):         at android.view.View.measure(View.java:8224)
    E/GeckoAppShell(10496):         at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:3132)
    E/GeckoAppShell(10496):         at android.widget.FrameLayout.onMeasure(FrameLayout.java:245)
    E/GeckoAppShell(10496):         at android.view.View.measure(View.java:8224)
    E/GeckoAppShell(10496):         at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:3132)
    E/GeckoAppShell(10496):         at android.widget.FrameLayout.onMeasure(FrameLayout.java:245)
    E/GeckoAppShell(10496):         at android.view.View.measure(View.java:8224)
    E/GeckoAppShell(10496):         at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:3132)
    E/GeckoAppShell(10496):         at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1012)
    E/GeckoAppShell(10496):         at android.widget.LinearLayout.measureVertical(LinearLayout.java:381)
    E/GeckoAppShell(10496):         at android.widget.LinearLayout.onMeasure(LinearLayout.java:304)
    E/GeckoAppShell(10496):         at com.android.internal.widget.WeightedLinearLayout.onMeasure(WeightedLinearLayout.java:60)
    E/GeckoAppShell(10496):         at android.view.View.measure(View.java:8224)
    E/GeckoAppShell(10496):         at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:3132)
    E/GeckoAppShell(10496):         at android.widget.FrameLayout.onMeasure(FrameLayout.java:245)
    E/GeckoAppShell(10496):         at android.view.View.measure(View.java:8224)
    E/GeckoAppShell(10496):         at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:3132)
    E/GeckoAppShell(10496):         at android.widget.FrameLayout.onMeasure(FrameLayout.java:245)
    E/GeckoAppShell(10496):         at android.view.View.measure(View.java:8224)
    E/GeckoAppShell(10496):         at android.view.ViewRoot.performTraversals(ViewRoot.java:812)
    E/GeckoAppShell(10496):         at android.view.ViewRoot.handleMessage(ViewRoot.java:1752)
    E/GeckoAppShell(10496):         at android.os.Handler.dispatchMessage(Handler.java:99)
    E/GeckoAppShell(10496):         at android.os.Looper.loop(Looper.java:123)
    E/GeckoAppShell(10496):         at android.app.ActivityThread.main(ActivityThread.java:4627)
    E/GeckoAppShell(10496):         at java.lang.reflect.Method.invokeNative(Native Method)
    E/GeckoAppShell(10496):         at java.lang.reflect.Method.invoke(Method.java:521)
    E/GeckoAppShell(10496):         at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:858)
    E/GeckoAppShell(10496):         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
    E/GeckoAppShell(10496):         at dalvik.system.NativeStart.main(Native Method)
    E/GeckoAppShell(10496): Caused by: java.lang.reflect.InvocationTargetException
    E/GeckoAppShell(10496):         at android.widget.TextView.<init>(TextView.java:365)
    E/GeckoAppShell(10496):         at java.lang.reflect.Constructor.constructNative(Native Method)
    E/GeckoAppShell(10496):         at java.lang.reflect.Constructor.newInstance(Constructor.java:446)
    E/GeckoAppShell(10496):         at android.view.LayoutInflater.createView(LayoutInflater.java:500)
    E/GeckoAppShell(10496):         ... 40 more
    E/GeckoAppShell(10496): Caused by: android.content.res.Resources$NotFoundException: File res/color/primary_text.xml from color state list resource ID #0x0
    E/GeckoAppShell(10496):         at android.content.res.Resources.loadColorStateList(Resources.java:1817)
    E/GeckoAppShell(10496):         at android.content.res.TypedArray.getColorStateList(TypedArray.java:342)
    E/GeckoAppShell(10496):         at android.widget.TextView.<init>(TextView.java:434)
    E/GeckoAppShell(10496):         ... 44 more
    E/GeckoAppShell(10496): Caused by: android.content.res.Resources$NotFoundException: File res/color/primary_text.xml from xml type colorstatelist resource ID #0x0
    E/GeckoAppShell(10496):         at android.content.res.Resources.loadXmlResourceParser(Resources.java:1924)
    E/GeckoAppShell(10496):         at android.content.res.Resources.loadColorStateList(Resources.java:1812)
    E/GeckoAppShell(10496):         ... 46 more

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

2.2 works in a weird way while resolving colors. When it tries to resolve a "?android:attr/" it tries to find the resources in android, and not in application package. This results in faults. This was resolved somewhere in 2.3.4 and the latest ones work fine.

To fix this, I don't have any other option than to copy the android XML's we use and change the values.

(?android:attr/TextAppearanceLargePopupMenu is not available until 11, and we can't override it in styles to prevent crashes in 2.2).

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cad82c3b69bc