861338 - [browserconsole] Cache Console.jsm API calls with ConsoleAPIStorage.jsm

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Mihai Sucan [:msucan]]

We should cache Console.jsm API calls with ConsoleAPIStorage.jsm such that the messages show in the Browser Console even if it was not open at the time of the API call.

Comment 1

[Mihai Sucan [:msucan]]

Attachment: proposed patch

This is the proposed patch.

I changed _consoleStorage from an object to a map in the hope that's more optimized for our actual use-case.

Since we can't tell if messages are being logged during private browsing, should we clear the "jsm" storage whenever pb-last-context-exited?

Comment 2

[Mihai Sucan [:msucan]]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=3860644c4fed

Comment 3

[Mihai Sucan [:msucan]]

Landed: https://hg.mozilla.org/integration/fx-team/rev/f4ec1953f7e5

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f4ec1953f7e5