Closed
Bug 861395
Opened 11 years ago
Closed 11 years ago
Log the original exception stack trace and add some paranoid exception checks
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox22 wontfix, firefox23 fixed)
RESOLVED
FIXED
Firefox 23
People
(Reporter: cpeterson, Assigned: cpeterson)
Details
Attachments
(2 files, 1 obsolete file)
|
1.99 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
|
2.41 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Part 1: Log the `cause` exception that we report to Socorro
Attachment #736983 -
Flags: review?(bugmail.mozilla)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Part 2: Still try to report exception if the exception reporter throws an exception.
Attachment #736984 -
Flags: review?(bugmail.mozilla)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 736983 [details] [diff] [review] part-1-log-original-exception.patch Review of attachment 736983 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #736983 -
Flags: review?(bugmail.mozilla) → review+
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 736984 [details] [diff] [review] part-2-ignore-exception-reporter-exceptions.patch Review of attachment 736984 [details] [diff] [review]: ----------------------------------------------------------------- What case does this catch that wasn't caught before? If an exception is thrown anywhere stackTrace will end up null and so nothing will be reported, so I don't see how this helps.
|
|
Assignee | |
Comment 5•11 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #4) > What case does this catch that wasn't caught before? If an exception is > thrown anywhere stackTrace will end up null and so nothing will be reported, > so I don't see how this helps. oops! <:) An earlier version of this patch only had the try {} around the SharedPreferences code because I wondered whether writing SharedPreferences after we just received an OutOfMemoryError could fail with another OutOfMemoryError. It was a purely hypothetical concern.
Attachment #736984 -
Attachment is obsolete: true
Attachment #736984 -
Flags: review?(bugmail.mozilla)
Attachment #737030 -
Flags: review?(bugmail.mozilla)
|
|
Assignee | |
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f896188292b
status-firefox22:
--- → wontfix
status-firefox23:
--- → fixed
Whiteboard: [keep open]
Target Milestone: --- → Firefox 23
|
|
||
Comment 7•11 years ago
|
||
Comment on attachment 737030 [details] [diff] [review] part-2-ignore-exception-reporter-exceptions-v2.patch r=me with the compile error fixed.
Attachment #737030 -
Flags: review?(bugmail.mozilla) → review+
|
||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7f896188292b
|
|
Assignee | |
Comment 9•11 years ago
|
||
Landed patch 2 with compile error fixed <:) https://hg.mozilla.org/integration/mozilla-inbound/rev/f91e963cad33
Whiteboard: [keep open]
|
|
||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f91e963cad33
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•