861486 - Need to update emulator in tooltool for B2G emulator testing for Bug 860585

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Edgar Chen [:edgar] (PTO until 02/09)]

We need to update the emulator used by TBPL emulator tests to pick up a fix for bug 860585, specifically the commit https://github.com/mozilla-b2g/platform_external_qemu/commit/4aa21d60a6ba2927122d82ceb433c3e4f690176f

Thanks

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

jgriffin, please generate the emulator build for us to put on tooltool.

Comment 2

[Jonathan Griffin (:jgriffin)]

emulator build:  http://ec2-107-20-108-245.compute-1.amazonaws.com/jenkins/job/b2g-build/1765/artifact/package.zip

Comment 4

[Justin Wood (:Callek)]

Attachment: [m-c] emulator

Comment 5

[Jonathan Griffin (:jgriffin)]

The patch looks fine, we'll need to do a full try run before checking this in.  I'll kick one off.

Comment 6

[Jonathan Griffin (:jgriffin)]

pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=bd87967002c8

Comment 7

[Jonathan Griffin (:jgriffin)]

Pushed to try again along with the patch from bug 840315, which may be necessary to avoid breaking font-sensitive tests:  https://tbpl.mozilla.org/?tree=Try&rev=424e1b710ce9

Comment 8

[Jonathan Griffin (:jgriffin)]

These try jobs were pretty bad, but most of that was fixed up in bug 840315.  I've just pushed again to try: https://tbpl.mozilla.org/?tree=Try&rev=631db7a026f9

Comment 9

[Jonathan Griffin (:jgriffin)]

Attachment: Update the emulator,

Try run was green.  I updated the patch to account for some bitrot, bit looks good to land.

Comment 10

[Jonathan Griffin (:jgriffin)]

checkin-needed for mozilla-b2g18 as well, when this migrates to mozilla-central

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/32fc13973b34

Is this exact patch what's needed on b2g18?

Comment 12

[Jonathan Griffin (:jgriffin)]

it may not apply cleanly to mozilla-b2g18.  I'll uplift it after it hits m-c.

Comment 13

[Jonathan Griffin (:jgriffin)]

Turns out we need v1-train emulators for mozilla-b2g18; will have to handle that with a separate bug.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/32fc13973b34