861512 - Uploading an image by pasting does not work on Nightly

Status: VERIFIED FIXED

(Tech Evangelism Graveyard :: English US, defect)

Description

[jimmythetronlegacy]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:23.0) Gecko/20130413 Firefox/23.0
Build ID: 20130413030927

Steps to reproduce:

-Navigate to http://www.imgur.com on Nightly 23.0a1
-Paste a section of an image copied from mspaint


Actual results:

The upload image dialog appears but not the image, and this happens in the javascript log:
Error: ReferenceError: elem is not defined
Source File: http://s.imgur.com/min/global_js?1365705716
Line: 58


Expected results:

The image should have pasted to the uploader and been able to be uploaded, as happens on mainline Firefox, but not Nightly.

Comment 1

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/dfeacbbb793d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130311 Firefox/22.0 ID:20130311092347
Bad:
http://hg.mozilla.org/mozilla-central/rev/7433bc4545c9
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130311 Firefox/22.0 ID:20130311165838
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=dfeacbbb793d&tochange=7433bc4545c9


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/875c77fe1e79
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130311 Firefox/22.0 ID:20130311082346
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/b123c8210d41
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130311 Firefox/22.0 ID:20130311085346
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=875c77fe1e79&tochange=b123c8210d41

Regressed by: Bug 407983

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Gavin: Neil's away until June 10th so do you have someone else willing to take on this regression?  It seems like a very common use case.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Smaug, any chance you could look into this, or suggest someone else who could?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Is this Windows only or cross platform?

Comment 5

[Alice0775 White]

I cannot reproduce the problem any more. The "BAD" build mentioned in comment #1 also works fine.
Maybe, the site was changed their code.

I confirmed in the following latest Nightly23.0a3 and Aurora22.0a2.

http://hg.mozilla.org/mozilla-central/rev/261d6997d1d1
Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20130415 Firefox/23.0 ID:20130415030812

http://hg.mozilla.org/releases/mozilla-aurora/rev/b6d86fda0787
Mozilla/5.0 (X11; Linux i686; rv:22.0) Gecko/20130415 Firefox/22.0 ID:20130415004014

http://hg.mozilla.org/mozilla-central/rev/261d6997d1d1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130415 Firefox/23.0 ID:20130415030812

http://hg.mozilla.org/releases/mozilla-aurora/rev/b6d86fda0787
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130415 Firefox/22.0 ID:20130415004014

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

reporter, can you still reproduce this?

Comment 8

[Alice0775 White]

(In reply to Olli Pettay [:smaug] from comment #6)
> reporter, can you still reproduce this?

Reproduced in 
http://hg.mozilla.org/mozilla-central/rev/0e45f1b9521f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130427 Firefox/23.0 ID:20130427030919
And 
http://hg.mozilla.org/releases/mozilla-aurora/rev/558d4c759bae
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130427 Firefox/22.0 ID:20130427004014

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

ok. But it is possible that I won't have time to look at this before Thursday.

Comment 10

[Alice0775 White]

In global_js, the Line: 58 is as follows:

  initPasteUploadMozilla: function () {
    var a = this;
    var b = this._.el.$FFPasteBox;
    handlePaste = function (d, c) {
      var f = c.innerHTML;
      if (d && d.clipboardData && d.clipboardData.getData) {
        if (/text\/html/.test(d.clipboardData.types)) {
          c.innerHTML = d.clipboardData.getData("text/html")
        } else {
          if (/text\/plain/.test(d.clipboardData.types)) {
            c.innerHTML = d.clipboardData.getData("text/plain")
          } else {
            c.innerHTML = ""
          }
        }
        waitForPasteData(elem, f);
        if (d.preventDefault) {
          d.stopPropagation();
          d.preventDefault()
        }
        return false
      } else {
        waitForPasteData(c, f);
        return true
      }
    };

Before landing Bug 407983, just execute waitForPasteData(c, f);
After landing Bug 407983, we support event.clipboardData for paste event.
So, the code path is different, waitForPasteData(elem, f) will execute, but 'elem' is defined nowhere.


I think that this is the site problem(something is missing or typo in global_js).

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Yeah, based on that, ->evang

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

I have submitted a bug report on imgur.com's site letting them know this is occurring in the FF22 builds which are going to be released to general audience on June 25th, 2013.

Comment 13

[Alex Keybl [:akeybl]]

Still not working sadly, but also not absolutely critical. We'll try outreach one more time and then untrack.

Comment 14

[christopher]

Imgur team is looking into this.

Comment 15

[christopher]

Imgur confirms they will have a fix in place before the release of FF22.

Comment 16

[Cornel Ionce [:noni]]

Mozilla/5.0 (Windows NT 6.1; rv:22.0) Gecko/20100101 Firefox/22.0
Mozilla/5.0 (Windows NT 6.1; rv:23.0) Gecko/20100101 Firefox/23.0

Verified as fixed on Firefox 22 (build ID: 20130618035212) and Firefox 23 beta 5 (build ID: 20130711122148)