Closed Bug 861528 Opened 7 years ago Closed 7 years ago

$user->can_enter_product() now returns the product object instead of 1

Categories

(Bugzilla :: Documentation, defect)

4.0.10
defect
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 4.0

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

Attachments

(1 file)

In bug 22353, $user->can_enter_product() has been changed to return the product object instead of 1 when the user can enter it. But the POD still says that this method returns 1 on success. As this method is used in security checks, it's important that the documentation remains accurate. This affects Bugzilla 4.0 and newer.
Attached patch patch, v1Splinter Review
Asking glob as he reviewed the original patch. :)
Assignee: documentation → LpSolit
Status: NEW → ASSIGNED
Attachment #737144 - Flags: review?(glob)
Comment on attachment 737144 [details] [diff] [review]
patch, v1

r=glob
Attachment #737144 - Flags: review?(glob) → review+
Flags: approval?
Flags: approval?
Flags: approval4.4+
Flags: approval4.2+
Flags: approval4.0+
Flags: approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/User.pm
Committed revision 8610.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/User.pm
Committed revision 8543.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified Bugzilla/User.pm
Committed revision 8204.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/User.pm
Committed revision 7751.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.