$user->can_enter_product() now returns the product object instead of 1

RESOLVED FIXED in Bugzilla 4.0

Status

()

Bugzilla
Documentation
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

4.0.10
Bugzilla 4.0
Bug Flags:
approval +
approval4.4 +
approval4.2 +
approval4.0 +

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
In bug 22353, $user->can_enter_product() has been changed to return the product object instead of 1 when the user can enter it. But the POD still says that this method returns 1 on success. As this method is used in security checks, it's important that the documentation remains accurate. This affects Bugzilla 4.0 and newer.
(Assignee)

Comment 1

4 years ago
Created attachment 737144 [details] [diff] [review]
patch, v1

Asking glob as he reviewed the original patch. :)
Assignee: documentation → LpSolit
Status: NEW → ASSIGNED
Attachment #737144 - Flags: review?(glob)
Comment on attachment 737144 [details] [diff] [review]
patch, v1

r=glob
Attachment #737144 - Flags: review?(glob) → review+
Flags: approval?
(Assignee)

Updated

4 years ago
Flags: approval?
Flags: approval4.4+
Flags: approval4.2+
Flags: approval4.0+
Flags: approval+
(Assignee)

Comment 3

4 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/User.pm
Committed revision 8610.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/User.pm
Committed revision 8543.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified Bugzilla/User.pm
Committed revision 8204.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/User.pm
Committed revision 7751.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.