Closed Bug 861528 Opened 7 years ago Closed 7 years ago
_enter _product() now returns the product object instead of 1
In bug 22353, $user->can_enter_product() has been changed to return the product object instead of 1 when the user can enter it. But the POD still says that this method returns 1 on success. As this method is used in security checks, it's important that the documentation remains accurate. This affects Bugzilla 4.0 and newer.
Asking glob as he reviewed the original patch. :)
Assignee: documentation → LpSolit
Status: NEW → ASSIGNED
Attachment #737144 - Flags: review?(glob)
Comment on attachment 737144 [details] [diff] [review] patch, v1 r=glob
Attachment #737144 - Flags: review?(glob) → review+
Committing to: bzr+ssh://firstname.lastname@example.org/bugzilla/trunk/ modified Bugzilla/User.pm Committed revision 8610. Committing to: bzr+ssh://email@example.com/bugzilla/4.4/ modified Bugzilla/User.pm Committed revision 8543. Committing to: bzr+ssh://firstname.lastname@example.org/bugzilla/4.2/ modified Bugzilla/User.pm Committed revision 8204. Committing to: bzr+ssh://email@example.com/bugzilla/4.0/ modified Bugzilla/User.pm Committed revision 7751.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.