Last Comment Bug 861528 - $user->can_enter_product() now returns the product object instead of 1
: $user->can_enter_product() now returns the product object instead of 1
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Documentation (show other bugs)
: 4.0.10
: All All
: -- normal (vote)
: Bugzilla 4.0
Assigned To: Frédéric Buclin
: default-qa
Mentors:
Depends on: 22353
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-13 10:10 PDT by Frédéric Buclin
Modified: 2013-04-15 14:28 PDT (History)
2 users (show)
LpSolit: approval+
LpSolit: approval4.4+
LpSolit: approval4.2+
LpSolit: approval4.0+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch, v1 (1.28 KB, patch)
2013-04-13 10:14 PDT, Frédéric Buclin
glob: review+
Details | Diff | Review

Description Frédéric Buclin 2013-04-13 10:10:59 PDT
In bug 22353, $user->can_enter_product() has been changed to return the product object instead of 1 when the user can enter it. But the POD still says that this method returns 1 on success. As this method is used in security checks, it's important that the documentation remains accurate. This affects Bugzilla 4.0 and newer.
Comment 1 Frédéric Buclin 2013-04-13 10:14:20 PDT
Created attachment 737144 [details] [diff] [review]
patch, v1

Asking glob as he reviewed the original patch. :)
Comment 2 Byron Jones ‹:glob› 2013-04-15 01:10:11 PDT
Comment on attachment 737144 [details] [diff] [review]
patch, v1

r=glob
Comment 3 Frédéric Buclin 2013-04-15 14:28:52 PDT
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/User.pm
Committed revision 8610.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/User.pm
Committed revision 8543.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified Bugzilla/User.pm
Committed revision 8204.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/User.pm
Committed revision 7751.

Note You need to log in before you can comment on or make changes to this bug.