861605 - Make the arguments to Window.alert, Window.confirm optional

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://html5.org/tools/web-apps-tracker?from=7831&to=7832
https://www.w3.org/Bugs/Public/show_bug.cgi?id=21587

Comment 1

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 2

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 3

[Andrea Marchesini [:baku]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=254a1c0be923

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 742692 [details] [diff] [review]
patch

Review of attachment 742692 [details] [diff] [review]:
-----------------------------------------------------------------

Would be nice to have a test, but I guess it's going to be annoying to close the dialog again. Please try to write one, but don't spend too much time on it if it doesn't work out.

Comment 5

[Andrea Marchesini [:baku]]

Attachment: patch

a small mochitest has been added.

https://tbpl.mozilla.org/?tree=Try&rev=1d53f920a815

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d82aee516d10

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Needed to rev the uuids to fix test failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/44cfaf0cc991

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d82aee516d10
https://hg.mozilla.org/mozilla-central/rev/44cfaf0cc991

Comment 9

[Jean-Yves Perrier [:teoli]]

Added info in:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/23
https://developer.mozilla.org/en-US/docs/Web/API/window.confirm
https://developer.mozilla.org/en-US/docs/Web/API/window.alert