Closed Bug 861605 Opened 8 years ago Closed 8 years ago

Make the arguments to Window.alert, Window.confirm optional

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: Ms2ger, Assigned: baku)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 3 obsolete files)

Attached patch patch (obsolete) — Splinter Review
Attachment #742363 - Flags: review?(Ms2ger)
Assignee: nobody → amarchesini
Attached patch patch (obsolete) — Splinter Review
Attachment #742363 - Attachment is obsolete: true
Attachment #742363 - Flags: review?(Ms2ger)
Attachment #742387 - Flags: review?(Ms2ger)
Attached patch patch (obsolete) — Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=254a1c0be923
Attachment #742387 - Attachment is obsolete: true
Attachment #742387 - Flags: review?(Ms2ger)
Attachment #742692 - Flags: review?(Ms2ger)
Comment on attachment 742692 [details] [diff] [review]
patch

Review of attachment 742692 [details] [diff] [review]:
-----------------------------------------------------------------

Would be nice to have a test, but I guess it's going to be annoying to close the dialog again. Please try to write one, but don't spend too much time on it if it doesn't work out.
Attachment #742692 - Flags: review?(Ms2ger) → review+
Attached patch patchSplinter Review
a small mochitest has been added.

https://tbpl.mozilla.org/?tree=Try&rev=1d53f920a815
Attachment #742692 - Attachment is obsolete: true
Attachment #742990 - Flags: review+
Keywords: checkin-needed
Keywords: dev-doc-needed
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.