The default bug view has changed. See this FAQ.

Make the arguments to Window.alert, Window.confirm optional

RESOLVED FIXED in mozilla23

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ms2ger, Assigned: baku)

Tracking

({dev-doc-complete})

Trunk
mozilla23
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

4 years ago
http://html5.org/tools/web-apps-tracker?from=7831&to=7832
https://www.w3.org/Bugs/Public/show_bug.cgi?id=21587
(Assignee)

Comment 1

4 years ago
Created attachment 742363 [details] [diff] [review]
patch
Attachment #742363 - Flags: review?(Ms2ger)
(Assignee)

Updated

4 years ago
Assignee: nobody → amarchesini
(Assignee)

Comment 2

4 years ago
Created attachment 742387 [details] [diff] [review]
patch
Attachment #742363 - Attachment is obsolete: true
Attachment #742363 - Flags: review?(Ms2ger)
Attachment #742387 - Flags: review?(Ms2ger)
(Assignee)

Comment 3

4 years ago
Created attachment 742692 [details] [diff] [review]
patch

https://tbpl.mozilla.org/?tree=Try&rev=254a1c0be923
Attachment #742387 - Attachment is obsolete: true
Attachment #742387 - Flags: review?(Ms2ger)
Attachment #742692 - Flags: review?(Ms2ger)
(Reporter)

Comment 4

4 years ago
Comment on attachment 742692 [details] [diff] [review]
patch

Review of attachment 742692 [details] [diff] [review]:
-----------------------------------------------------------------

Would be nice to have a test, but I guess it's going to be annoying to close the dialog again. Please try to write one, but don't spend too much time on it if it doesn't work out.
Attachment #742692 - Flags: review?(Ms2ger) → review+
(Assignee)

Comment 5

4 years ago
Created attachment 742990 [details] [diff] [review]
patch

a small mochitest has been added.

https://tbpl.mozilla.org/?tree=Try&rev=1d53f920a815
Attachment #742692 - Attachment is obsolete: true
Attachment #742990 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/d82aee516d10
Flags: in-testsuite+
Keywords: checkin-needed
Needed to rev the uuids to fix test failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/44cfaf0cc991
https://hg.mozilla.org/mozilla-central/rev/d82aee516d10
https://hg.mozilla.org/mozilla-central/rev/44cfaf0cc991
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23

Updated

4 years ago
Keywords: dev-doc-needed
Added info in:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/23
https://developer.mozilla.org/en-US/docs/Web/API/window.confirm
https://developer.mozilla.org/en-US/docs/Web/API/window.alert
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.