Last Comment Bug 861605 - Make the arguments to Window.alert, Window.confirm optional
: Make the arguments to Window.alert, Window.confirm optional
Status: RESOLVED FIXED
: dev-doc-complete
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla23
Assigned To: Andrea Marchesini [:baku]
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-14 00:59 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2013-08-15 03:49 PDT (History)
4 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.50 KB, patch)
2013-04-26 07:35 PDT, Andrea Marchesini [:baku]
no flags Details | Diff | Splinter Review
patch (1.17 KB, patch)
2013-04-26 08:27 PDT, Andrea Marchesini [:baku]
no flags Details | Diff | Splinter Review
patch (1.88 KB, patch)
2013-04-27 03:10 PDT, Andrea Marchesini [:baku]
Ms2ger: review+
Details | Diff | Splinter Review
patch (4.57 KB, patch)
2013-04-29 03:44 PDT, Andrea Marchesini [:baku]
amarchesini: review+
Details | Diff | Splinter Review

Comment 1 Andrea Marchesini [:baku] 2013-04-26 07:35:33 PDT
Created attachment 742363 [details] [diff] [review]
patch
Comment 2 Andrea Marchesini [:baku] 2013-04-26 08:27:37 PDT
Created attachment 742387 [details] [diff] [review]
patch
Comment 3 Andrea Marchesini [:baku] 2013-04-27 03:10:04 PDT
Created attachment 742692 [details] [diff] [review]
patch

https://tbpl.mozilla.org/?tree=Try&rev=254a1c0be923
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2013-04-28 00:28:56 PDT
Comment on attachment 742692 [details] [diff] [review]
patch

Review of attachment 742692 [details] [diff] [review]:
-----------------------------------------------------------------

Would be nice to have a test, but I guess it's going to be annoying to close the dialog again. Please try to write one, but don't spend too much time on it if it doesn't work out.
Comment 5 Andrea Marchesini [:baku] 2013-04-29 03:44:34 PDT
Created attachment 742990 [details] [diff] [review]
patch

a small mochitest has been added.

https://tbpl.mozilla.org/?tree=Try&rev=1d53f920a815
Comment 6 Ryan VanderMeulen [:RyanVM] 2013-04-29 05:37:07 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/d82aee516d10
Comment 7 Ryan VanderMeulen [:RyanVM] 2013-04-29 06:39:32 PDT
Needed to rev the uuids to fix test failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/44cfaf0cc991

Note You need to log in before you can comment on or make changes to this bug.