Make the arguments to Window.alert, Window.confirm optional

RESOLVED FIXED in mozilla23

Status

()

defect
RESOLVED FIXED
6 years ago
4 months ago

People

(Reporter: Ms2ger, Assigned: baku)

Tracking

({dev-doc-complete})

Trunk
mozilla23
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Posted patch patch (obsolete) — Splinter Review
Attachment #742363 - Flags: review?(Ms2ger)
Assignee: nobody → amarchesini
Posted patch patch (obsolete) — Splinter Review
Attachment #742363 - Attachment is obsolete: true
Attachment #742363 - Flags: review?(Ms2ger)
Attachment #742387 - Flags: review?(Ms2ger)
Posted patch patch (obsolete) — Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=254a1c0be923
Attachment #742387 - Attachment is obsolete: true
Attachment #742387 - Flags: review?(Ms2ger)
Attachment #742692 - Flags: review?(Ms2ger)
Comment on attachment 742692 [details] [diff] [review]
patch

Review of attachment 742692 [details] [diff] [review]:
-----------------------------------------------------------------

Would be nice to have a test, but I guess it's going to be annoying to close the dialog again. Please try to write one, but don't spend too much time on it if it doesn't work out.
Attachment #742692 - Flags: review?(Ms2ger) → review+
Posted patch patchSplinter Review
a small mochitest has been added.

https://tbpl.mozilla.org/?tree=Try&rev=1d53f920a815
Attachment #742692 - Attachment is obsolete: true
Attachment #742990 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d82aee516d10
https://hg.mozilla.org/mozilla-central/rev/44cfaf0cc991
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Keywords: dev-doc-needed
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.