861793 - [updates] Checking for an app update that contains the same filename, but different app manifest/contents fails to find the app update

Status: RESOLVED WONTFIX

(Core Graveyard :: DOM: Apps, defect)

Description

[Jason Smith [:jsmith]]

Build: B2G 18 4/15/2013
Device: Unagi

STR

1. Install a packaged app
2. Change the packaged app on the server to have different app contents and a different manifest.webapp, but keep the zip file name the same
3. Check for updates on the phone

Expected

An update available should be found for that app.

Actual

No update available is found.

Comment 1

[Jason Smith [:jsmith]]

Attachment: Before Update

Comment 2

[Jason Smith [:jsmith]]

Attachment: After Update

Comment 3

[Jason Smith [:jsmith]]

Attachment: Webapps JSON

Comment 4

[Julien Wajsberg [:julienw]]

Have you changed the update (mini manifest) file too ?

Comment 5

[Jason Smith [:jsmith]]

(In reply to Julien Wajsberg [:julienw] from comment #4)
> Have you changed the update (mini manifest) file too ?

No. I kept the mini-manifest the same, but only changed the resulting zip file. So in that case, the etag of the mini-manifest stayed the same, but the packaged app etag changed.

Comment 6

[Jason Smith [:jsmith]]

Actually now given comment 5, this probably doesn't block. Marketplace's use case for updating apps requires modification of the mini-manifest, so we'll never hit this issue with users making use of marketplace. We might still want to fix this eventually, however.

Comment 7

[Julien Wajsberg [:julienw]]

I really think this was wanted: if the mini manifest is not changed, we don't bother checking the packaged zip.

This is also desirable if the server does not support ETag: since we don't support "If-Modified-Since" yet, we would need to download the package to check its hash. We don't want do to that if the mini manifest hasn't changed.

So I'm very tempted to close WONTFIX.

Comment 8

[Jason Smith [:jsmith]]

Fair enough, sounds fine to me to close then.