Closed Bug 861852 Opened 7 years ago Closed 7 years ago

Telemetry data from the remote protocol always appear in the remote buckets

Categories

(DevTools :: Debugger, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: past, Assigned: past)

Details

Attachments

(1 file)

This bug is of the "instanceof breaks across globals" variety. Converting the instanceof test to a structured typing test, breaks xpcshell tests though. The plot thickens...
Priority: -- → P2
Attached patch Patch v1Splinter Review
Using a structural type test works. The other problem that it surfaced was that in xpcshell tests DC_requester can be called from the other clients that don't have a _transport property, which previously made the instanceof test bogus, but with the new test it threw an error. Added a getter to the _transport of the DebuggerClient to each of the other clients.
Attachment #737530 - Flags: review?(rcampbell)
Attachment #737530 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/mozilla-central/rev/8c8c9b98d6c1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.