861857 - Typeinference: Fault in intersectionEmpty

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Hannes Verschore [:h4writer]]

Obvious by just reading the code. This was meant to test "this" and "other". Not twice "this". Introduced in 849781. Will have to get uplifted.

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: patch

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 737482 [details] [diff] [review]
patch

Review of attachment 737482 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch.

Comment 3

[Hannes Verschore [:h4writer]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb95b49e094c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eb95b49e094c

Comment 5

[Hannes Verschore [:h4writer]]

Comment on attachment 737482 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Bug 849781

User impact if declined:
For now we haven't hit a bug (I think), but I think it is possible to create a testcase that misbehaves

Testing completed (on m-c, etc.): m-i: 1 day, m-c: 1/2 day

Risk to taking this patch (and alternatives if risky): 
Very low risk. Inlining of functions is now a bit stricter. I.e. that code now uses the general case, instead of the special case.

String or IDL/UUID changes made by this patch:
/

Comment 6

[bhavana bajaj [:bajaj]]

Comment on attachment 737482 [details] [diff] [review]
patch

low risk uplift of a Fx22 regression .

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/feb577773a0b