Move TreeColumns to WebIDL

RESOLVED FIXED in mozilla23

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug)

Trunk
mozilla23
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 737497 [details] [diff] [review]
Patch v1
Attachment #737497 - Flags: review?(bzbarsky)
(Assignee)

Updated

5 years ago
Blocks: 580070
Comment on attachment 737497 [details] [diff] [review]
Patch v1

>+addExternalIface('MozTreeBoxObject', nativeType='nsITreeBoxObject')

I think this needs notflattened=True

>+interface TreeColumns {

[NoInterfaceObject], please.  I'm surprised this didn't fail the "list of interfaces we're exposing on the global" test.. or does that not catch webidl things?

> NS_INTERFACE_MAP_BEGIN(nsTreeColumns)

NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION

r=me with those issues fixed.

Fwiw, if you put the WebIDL methods _after_ the XPCOM ones in the .cpp, I bet your diff would have been smaller...
Attachment #737497 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

5 years ago
(In reply to Boris Zbarsky (:bz) from comment #1)
> >+interface TreeColumns {
> 
> [NoInterfaceObject], please.  I'm surprised this didn't fail the "list of
> interfaces we're exposing on the global" test.. or does that not catch
> webidl things?

Sure does. But the test whitelists TreeColumns.

Comment 3

5 years ago
IIRC because TreeColumns has been exposed to global scope for ages.
Huh.  Why?  It's not nsIDOMTreeColumns....  Is it just because it had classinfo?

Comment 5

5 years ago
IIRC yes. It uses DOMClassInfo and that ends up putting it to global scope.
(don't recall how that happens..)
Hmm.  I guess we use it on the RHS of instanceof too.  :(

Check this in as-is, I guess.  :(
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/0d50cb959c46
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.