[b2g-ril] Call waiting feature is not working on Geeksphone Peak devices and on Leo

RESOLVED FIXED in Firefox 23, Firefox OS v1.1hd

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jaoo, Assigned: Geeksphone)

Tracking

Trunk
mozilla23
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:leo+, firefox21 wontfix, firefox22 wontfix, firefox23 fixed, b2g18 verified, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)

Details

(Whiteboard: [fixed-in-birch], leorun3)

Attachments

(3 attachments)

Call waiting feature is not working properly on Geekphone Peak devices due a extra uint_32 field in the response from the RIL_REQUEST_GET_CURRENT_CALLS parcel. We need to add a new RIL quirk for reading it as we did with other RIL quirks.
(Assignee)

Comment 1

4 years ago
Created attachment 737515 [details] [diff] [review]
V1

Add quirk for call waiting feature in ril_worker.js
Attachment #737515 - Flags: review?(vyang)
Attachment #737515 - Flags: review?(vyang) → review+
https://hg.mozilla.org/projects/birch/rev/4a7f5c87ff79
Whiteboard: [fixed-in-birch]
https://hg.mozilla.org/mozilla-central/rev/4a7f5c87ff79
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
This issue happens on leo as well, so leo?
blocking-b2g: --- → leo?
Summary: [b2g-ril] Call waiting feature is not working on Geeksphone Peak devices → [b2g-ril] Call waiting feature is not working on Geeksphone Peak devices and on Leo
Blocks: 880726
Created attachment 761934 [details] [diff] [review]
b2g18 patch
No longer blocks: 880726
Depends on: 880726
Triage - blocking as function fail.
blocking-b2g: leo? → leo+

Comment 7

4 years ago
Fix not available yet when running the Leo testrun3.
Test case affected: #4377
Whiteboard: [fixed-in-birch] → [fixed-in-birch], leorun3
(Assignee)

Comment 8

4 years ago
Created attachment 762586 [details] [diff] [review]
ril_worker patch for 2ND call on V1.0.1

Patch that we are using on v1.0.1 for Geeksphone Peak.
(Assignee)

Comment 9

4 years ago
Needed to add ro.moz.ril.extra_int_2nd_call=true on build.prop

see: https://github.com/gp-b2g/device-gp-peak/blob/master/full_peak.mk#L24
(In reply to Geeksphone from comment #9)
> Needed to add ro.moz.ril.extra_int_2nd_call=true on build.prop
> 
> see: https://github.com/gp-b2g/device-gp-peak/blob/master/full_peak.mk#L24

We've already adding a quirk for leo deivces in bug 880726.
https://hg.mozilla.org/releases/mozilla-b2g18/rev/1b4b8d9d995b
status-b2g18: --- → fixed
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → wontfix
status-b2g-v1.1hd: --- → affected
status-firefox21: --- → wontfix
status-firefox22: --- → wontfix
status-firefox23: --- → fixed
https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/1b4b8d9d995b
status-b2g-v1.1hd: affected → fixed

Updated

4 years ago
Flags: in-moztrap?
Hi Anshul, is this on your radar?
Flags: needinfo?(anshulj)

Comment 14

4 years ago
Hsin-Yi, call waiting is working fine on leo device with commercial RIL.
Flags: needinfo?(anshulj)

Comment 15

4 years ago
Issue repros on 

Leo Build ID: 20130625070217
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/29933d1937db
Gaia: 1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
Platform Version: 18.1

Call waiting does not work on device with call forwarding and without call forwarding.  
https://bugzilla.mozilla.org/show_bug.cgi?id=882841

Comment 16

4 years ago
(In reply to Anshul from comment #14)
> Hsin-Yi, call waiting is working fine on leo device with commercial RIL.


Confirming, call waiting is working fine on Leo:  
 - the user can enable/disable "Call waiting" 
 - if enabled, when the user is on call, and a second call comes in, the user can hear a tone, able to put the fist call on hold, answer the second call, then quit the second call and return to the first call

Leo build info:
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/29933d1937db
Gaia   1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
Build  20130625070217
Version 18.1
status-b2g18: fixed → verified

Updated

4 years ago
Flags: in-moztrap?
You need to log in before you can comment on or make changes to this bug.