861955 - Use async favicon service for data/io

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Jordan Santell [:jsantell] [@jsantell]]

While digging through places stuff, found that the favicon APIs used in data/io are deprecated now
https://groups.google.com/forum/?fromgroups=#!topic/mozilla.dev.extensions/49KHKMGesCc

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Which explains the strange (or just not working) behaviour reported in bug 834942 https://bugzilla.mozilla.org/show_bug.cgi?id=834942#c1

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Now a duplicate of 834942

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

I take it back, this is a separate component.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: GH Pull Request 976

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #4)
> Created attachment 743313 [details]
> GH Pull Request 976

Nice work! just have some nits for the tests.

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 743313 [details]
GH Pull Request 976

I made a couple more requests in the pull about the tests, but I won't block on that.

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/de3984bec1e5706fb3a30024d6649200a55c26b0
Bug 861955: getFavicon async method in io/data

https://github.com/mozilla/addon-sdk/commit/1d939e92564b3ba98f1b169b7cb6b196326e82c0
Merge pull request #976 from jsantell/favicon

Bug 861955 getFavicon async method in io/data, r+=@erikvold