862084 - Crash [@ mozilla::dom::HTMLSelectElementBinding::item]

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox when loaded)

Nightly: bp-6173657e-ee58-4fdc-ae2a-a4c4d2130415

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Andrew McCreight [:mccr8]]

Presumably a regression from bug 841488.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yep:

33   getter Element item(unsigned long index);

Should be "Element?", I would think.  The spec needs this fixed too.

Comment 4

[Boris Zbarsky [:bzbarsky]]

And namedItem should be "object?", I would think.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

This only landed in 23 (Nightly) so flagging accordingly.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://tbpl.mozilla.org/?tree=Try&rev=46cfeb4cc627

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 738518 [details] [diff] [review]
Patch v1

r=me

Please do file a spec bug.

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://www.w3.org/Bugs/Public/show_bug.cgi?id=21735

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/2c13322af776

Comment 11

[Bogdan Maris, Desktop Test Engineering]

Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20100101 Firefox/23.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101 Firefox/23.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0

Verified as fixed on Firefox 23 Beta 1 (buildID: 20130625125232) and latest Nightly (buildID: 20130625031238).