Closed Bug 862140 Opened 12 years ago Closed 10 years ago

[Buri][Music Player] an audio file (wma file) with wrong extension (set to mp3) causes device to become painfully slow . This also happens for large number of MP3 files.

Categories

(Firefox OS Graveyard :: Gaia::Music, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:-)

RESOLVED WORKSFORME
blocking-b2g -

People

(Reporter: tkundu, Unassigned)

References

Details

(Keywords: perf, Whiteboard: [c= p= u= s=] [fixinmusic2])

DEFECT DESCRIPTION: (1)Insert one SD card with about >500 music files ( There must be 100 *.wma file renamed into *.mp3). This bug may not appear for small number of music files. You need to rename as many as 100 wma file into mp3 file. (2)Go to Music, it start scanning. You will see it is parsing wma renamed into mp3 files successfully. (3)The scanning will be blocked at some song, never going on (It can be wma file or Mp3 file) . Now you need to kill music player .--- NOK1 (4)try to launch the Music player again, it will start scanning again, but it will stopped at some other wma file or mp3 file. ...same NOKs appear again. REPRODUCING PROCEDURES: EXPECTED BEHAVIOUR: ASSOCIATE SPECIFICATION: TEST PLAN REFERENCE: TOOLS AND PLATFORMS USED: USER IMPACT: Serious, the music player nearly useless, if user want to listen to some music in this case, the phone will totally slow for other functions. REPRODUCING RATE: 100%(with the dedicated SD card)
blocking-b2g: --- → tef?
Tapas - what's the minimum number of renamed files that causes this issue? Unless it's a handful, this wouldn't be a blocker.
blocking-b2g: tef? → -
Flags: needinfo?(tkundu)
If I use 20 renamed files then I see it only once (Rebooting or killing music app does not produce same error in next launch). If I use 100 renamed files then i can produce it always. The problem is that it can parse some renamed files and it stuck randomly on some renamed file after that. This problem has some kind of randomness. It can be reproduced with large number of renamed file always.
Flags: needinfo?(tkundu)
Keywords: perf
Whiteboard: [c= p= u= s=]
Hema, this appears to be an issue with incorrect file types leading to some expensive processing. Is a fix for this targeted in any upcoming release?
Severity: blocker → normal
Flags: needinfo?(hkoka)
We are working on a new version of the music player currently targeted for 1.4. Marking this with a flag so we ensure this is addressed.
Flags: needinfo?(hkoka)
Whiteboard: [c= p= u= s=] → [c= p= u= s=] [fixinmusic2]
Is this still an issue now?
Flags: needinfo?(hkoka)
Priority: -- → P2
this is part of music2 bug backlog (some other priorities trumped work on next version of music app so far, but it is currently in the plan for 2.1/2.2)
Flags: needinfo?(hkoka)
This sound like it failures in the metadata parsing. We should be able to actually deal with that and just skip the file. Something like that. I'll see if I can create a test sample as I have no WMA files.
the samples I have make Gecko crash. We should fix this.
Not that was large number of actual MP3 (or a mix of MP3, MP4 and OGG) I didn't see any performance problems.
Depends on: 1075259
Depends on: 1069602
No longer depends on: 1075259
See Also: → 1077890
The only problem I see is that we actually wrongfully import the WMA file believing they are MP3. Tested on master. Feel free to reopen if you have a better test case to reproduce.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.