Last Comment Bug 862143 - stop loading Sherlock files from disk
: stop loading Sherlock files from disk
: addon-compat, dev-doc-complete
Product: Firefox
Classification: Client Software
Component: Search (show other bugs)
: unspecified
: All All
-- normal (vote)
: Firefox 24
Assigned To: :Gavin Sharp [email:]
: Florian Quèze [:florian] [:flo] (PTO until February 27)
Depends on: 854478
Blocks: 862137 862179
  Show dependency treegraph
Reported: 2013-04-15 17:21 PDT by :Gavin Sharp [email:]
Modified: 2015-10-09 23:51 PDT (History)
6 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (6.67 KB, patch)
2013-04-15 17:27 PDT, :Gavin Sharp [email:]
MattN+bmo: review+
Details | Diff | Splinter Review

Description User image :Gavin Sharp [email:] 2013-04-15 17:21:03 PDT
This patch removes support for loading Sherlock files from disk (profile, appdir). It doesn't remove support for loading them from the web (e.g. via window.sidebar.addSearchEngine).
Comment 1 User image :Gavin Sharp [email:] 2013-04-15 17:27:49 PDT
Created attachment 737767 [details] [diff] [review]
Comment 2 User image :Gavin Sharp [email:] 2013-04-15 17:28:26 PDT
(Applies on top of bug 854478)
Comment 3 User image :Gavin Sharp [email:] 2013-06-07 10:22:19 PDT
Comment 4 User image Ed Morley [:emorley] 2013-06-10 02:17:01 PDT
Comment 5 User image :Gavin Sharp [email:] 2013-06-10 11:09:47 PDT
We should probably relnote this: Sherlock-format search plugins in the application directory or profile will now no longer be loaded as of Firefox 24. This should affect very few users, but I think it's still worth noting.
Comment 6 User image :Gavin Sharp [email:] 2013-06-10 11:10:48 PDT
addon-compat: this also prevents Sherlock search plugins (.src) from loading from add-on search plugin locations.
Comment 7 User image :Gavin Sharp [email:] 2013-06-10 11:11:56 PDT
(though note bug 598697 means that this is only relevant to unpacked extensions to begin with)
Comment 8 User image bhavana bajaj [:bajaj] 2013-06-21 13:17:39 PDT
developer note for people using search-plugins.We may have broke a lot of these due to this change
Comment 9 User image Jean-Yves Perrier [:teoli] 2015-10-09 23:51:35 PDT
There is note there:

Note You need to log in before you can comment on or make changes to this bug.