Closed Bug 862143 Opened 7 years ago Closed 7 years ago

stop loading Sherlock files from disk

Categories

(Firefox :: Search, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 24
Tracking Status
relnote-firefox --- 24+

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

(Keywords: addon-compat, dev-doc-complete)

Attachments

(1 file)

This patch removes support for loading Sherlock files from disk (profile, appdir). It doesn't remove support for loading them from the web (e.g. via window.sidebar.addSearchEngine).
Attached patch patchSplinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #737767 - Flags: review?(mnoorenberghe+bmo)
(Applies on top of bug 854478)
Depends on: 854478
Attachment #737767 - Flags: review?(mnoorenberghe+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/b5b6bd4cb6a8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
We should probably relnote this: Sherlock-format search plugins in the application directory or profile will now no longer be loaded as of Firefox 24. This should affect very few users, but I think it's still worth noting.
relnote-firefox: --- → ?
addon-compat: this also prevents Sherlock search plugins (.src) from loading from add-on search plugin locations.
Keywords: addon-compat
(though note bug 598697 means that this is only relevant to unpacked extensions to begin with)
developer note for people using search-plugins.We may have broke a lot of these due to this change
You need to log in before you can comment on or make changes to this bug.