862143 - stop loading Sherlock files from disk

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

This patch removes support for loading Sherlock files from disk (profile, appdir). It doesn't remove support for loading them from the web (e.g. via window.sidebar.addSearchEngine).

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

(Applies on top of bug 854478)

Comment 3

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5b6bd4cb6a8

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b5b6bd4cb6a8

Comment 5

[:Gavin Sharp [email: [e-mail]]]

We should probably relnote this: Sherlock-format search plugins in the application directory or profile will now no longer be loaded as of Firefox 24. This should affect very few users, but I think it's still worth noting.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

addon-compat: this also prevents Sherlock search plugins (.src) from loading from add-on search plugin locations.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

(though note bug 598697 means that this is only relevant to unpacked extensions to begin with)

Comment 8

[bhavana bajaj [:bajaj]]

developer note for people using search-plugins.We may have broke a lot of these due to this change

Comment 9

[Jean-Yves Perrier [:teoli]]

There is note there: https://developer.mozilla.org/en-US/Firefox/Releases/24#Changes_for_add-on_and_Mozilla_developers