stop loading Sherlock files from disk

RESOLVED FIXED in Firefox 24

Status

()

Firefox
Search
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

({addon-compat, dev-doc-complete})

unspecified
Firefox 24
addon-compat, dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(relnote-firefox 24+)

Details

Attachments

(1 attachment)

This patch removes support for loading Sherlock files from disk (profile, appdir). It doesn't remove support for loading them from the web (e.g. via window.sidebar.addSearchEngine).
Blocks: 862137
Created attachment 737767 [details] [diff] [review]
patch
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #737767 - Flags: review?(mnoorenberghe+bmo)
(Applies on top of bug 854478)
Depends on: 854478
Blocks: 862179
Attachment #737767 - Flags: review?(mnoorenberghe+bmo) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5b6bd4cb6a8
Target Milestone: --- → Firefox 24

Comment 4

4 years ago
https://hg.mozilla.org/mozilla-central/rev/b5b6bd4cb6a8
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
We should probably relnote this: Sherlock-format search plugins in the application directory or profile will now no longer be loaded as of Firefox 24. This should affect very few users, but I think it's still worth noting.
relnote-firefox: --- → ?
addon-compat: this also prevents Sherlock search plugins (.src) from loading from add-on search plugin locations.
Keywords: addon-compat
(though note bug 598697 means that this is only relevant to unpacked extensions to begin with)
Keywords: dev-doc-needed
developer note for people using search-plugins.We may have broke a lot of these due to this change

Updated

4 years ago
relnote-firefox: ? → 24+
There is note there: https://developer.mozilla.org/en-US/Firefox/Releases/24#Changes_for_add-on_and_Mozilla_developers
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.