862173 - main thread I/O in update service

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Several guilty call sites:
- readStringFromInputStream/readStringFromFile/writeStringToFile
- cleanUpUpdatesDir
- _loadXMLFileIntoArray
- _verifyDownload
- others

I imagine some of this stuff might be difficult to convert to async/off-main-thread I/O using OS.File due to API requirements. But maybe there are some easy targets?

Comment 1

[Vladan Djeric (:vladan)]

I just got a 5 minute hang in Nightly while it downloaded and verified a full update on the main thread. Can we prioritize this work?

Comment 2

[Vladan Djeric (:vladan)]

The profile shows that the vast majority of time was spent in Downloader__VerifyDownload() -> nsCryptoHash::UpdateFromStream. I'm on Windows 10, using a magnetic HDD

Comment 3

[Robert Strong (they/them - no direct email)]

Definitely and with other security measures in place this can most likely be removed.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=587b075b0f73

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e188ddf011ae

Comment 6

[Robert Strong (they/them - no direct email)]

The attached a patch in progress (still need to fix a couple of more tests) disables this check for platforms when mar signing is enabled which is simple and covers all the cases we care about. I don't think it is worth moving it off the main thread since it is only needed when mar signing is disabled and all apps should move to mar signing just as Firefox has if they haven't already done so.

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

This should fix up the remaining test failure

pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=414794e29bf4

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/662ef65e5017

Comment 9

[(No longer employed by Mozilla) Aaron Klotz]

\o/

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/662ef65e5017