[meta] reduce costs from descendants of simple dynamic style changes (e.g., changing 'transform' in style attribute)

NEW
Unassigned

Status

()

P2
normal
5 years ago
3 years ago

People

(Reporter: dbaron, Unassigned)

Tracking

({meta, perf})

Trunk
meta, perf
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:-)

Details

(Whiteboard: [c=uniformity p= s= u=])

A number of the performance issue in Firefox OS related to style code are related to the cost of relatively simple dynamic style changes (such as changing 'transform' in a style attribute) that's the result of assigning new style contexts to the element's descendants.

Bug 779968 did some previous work to improve this case.

Two ideas on further improvements here are in bug 804975 and bug 862274.  I need to figure out which, if any, of these ideas are practical and how to move forward.

Updated

5 years ago
Blocks: 920921

Updated

5 years ago
Whiteboard: [c= p= s= u=]

Updated

5 years ago
Blocks: 935345

Updated

5 years ago
Blocks: 939260
I listed a few problems in bug 939460 where style flushes are preventing us from having smooth animations. Ideally this bug will be sufficient to close all of these. Given this I think this should be a harder blocker for 1.3.
blocking-b2g: --- → 1.3?
This is indeed critical.
blocking-b2g: --- → 1.3+
David, this came up in the rendering meeting, we talked about it a bit.  We think it's a blocker for 1.3 (Dec 9) - can you help us figure out how to handle this?
Flags: needinfo?(dbaron)
I think bug 931668 (already on dependency list) should make a big dent here, and heycam is working on that.
Flags: needinfo?(dbaron)
(And by "make a big dent here", I mean I think it will be sufficient to address the problems we're seeing.)
Thanks for the quick response, and I agree, that's a very big dent :).  I will roll this back to 1.3?, as we would want to get the results from bug 931668, and hopefully we won't need the rest for 1.3.
blocking-b2g: 1.3+ → 1.3?

Updated

5 years ago
Blocks: 944564

Updated

5 years ago
No longer blocks: 944564

Updated

5 years ago
Depends on: 944564

Comment 7

5 years ago
Minusing from 1.3 per Milan's comment 6. Renom if necessary after bug 931668 lands.

(In reply to Milan Sreckovic [:milan] from comment #6)
> Thanks for the quick response, and I agree, that's a very big dent :).  I
> will roll this back to 1.3?, as we would want to get the results from bug
> 931668, and hopefully we won't need the rest for 1.3.
blocking-b2g: 1.3? → -

Updated

5 years ago
No longer depends on: 944564

Updated

5 years ago
Priority: -- → P1
Whiteboard: [c= p= s= u=] → [c=progress p= s= u=]

Comment 8

5 years ago
FxOS Perf P1 as this has a direct negative impact on Frame Uniformity.

Updated

5 years ago
Whiteboard: [c=progress p= s= u=] → [c=uniformity p= s= u=]
We need this in order to make some of the new FxOS homescreen animations perform well.
Blocks: 988401
blocking-b2g: - → 1.5?
Blocks: 989848
No longer blocks: 988401
We shouldn't block on the meta--please nom the dependent bugs as necessary.
blocking-b2g: 1.5? → ---
Flags: needinfo?(kgrandon)
Summary: reduce costs from descendants of simple dynamic style changes (e.g., changing 'transform' in style attribute) → [meta] reduce costs from descendants of simple dynamic style changes (e.g., changing 'transform' in style attribute)
I'll nom as appropriate. Thanks!
Flags: needinfo?(kgrandon)
This is super nice to have, but I'm guessing this won't make 2.0.
feature-b2g: --- → -
Priority: P1 → P2
Blocks: 1017954
No longer blocks: 989848
If bug 862274 is a dupe of bug 931668 then there should only be bug 804975 left. We should try to wrap it up ASAP since this bug is causing significant delays all over FFOS.
Bug 1180120 could also help here.  Bug 1180118 is less directly related to comment 0 but could also help.
You need to log in before you can comment on or make changes to this bug.