862337 - SDK 1.14 leaks console/plain-text.js

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Andreas Wagner [:TheOne] [use NI]]

The SDK 1.14 leaks, get a bucket!

STR:
1. Install https://addons.mozilla.org/firefox/downloads/file/202844/youtube_html5_switch-v0.1.6-fx.xpi
2. Disable it
3. Go to about:compartments

The previous version of the add-on https://addons.mozilla.org/firefox/downloads/file/196208/youtube_html5_switch-v0.1.3.9-fx.xpi?src=editor uses SDK 1.13.2, has no code changes outside the SDK folders and does not leak.

Tested in Aurora and Nightly on Windows.

Comment 1

[Alexandre Poirot [:ochameau]]

I don't know exactly what's going on there, but I can see various dead wrappers being hold by the plain text console module: curry, self, traceback, prefs and merge

It basically means that plain text isn't nuked for some reason, whereas its dependencies are. And we are also keeping a reference to plain text object...
(sandboxes nuke is just a safety, we shouldn't be keeping any references in first place)

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

How much does this actually leak? Is this per-addon?

Comment 3

[Alexandre Poirot [:ochameau]]

I haven't investigated much. I'd say it happen for all addons, but it would be worth to give it a try with an empty addon.
And the leak isn't huge, it seems to leak console module and its sandbox.