862344 - Hide non-enumerable properties of parsed JSON in the network details

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

It is really nice to have a structured view of JSON responses in the Response tab.

Two requests though:

* Would it be possible to filter out the __proto__ entries? With heavily nested JSOn that is a lot of extra stuff that is not really part of the JSON response anyway.

* Would it be possible to see the raw request instead? I would like to see the response in plain unformatted text.

Comment 1

[Victor Porof [:vporof][:vp]]

(In reply to Stefan Arentz [:st3fan] from comment #0)
> 
> * Would it be possible to filter out the __proto__ entries? With heavily
> nested JSOn that is a lot of extra stuff that is not really part of the JSON
> response anyway.

Ok. I believe it would be useful to have this under a pref though.

> * Would it be possible to see the raw request instead? I would like to see
> the response in plain unformatted text.

Yes, there's bug 859138 filed.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Why under a pref? It makes no sense to show this info. It is not part of the original response and has nothing to do with JSON.

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Stefan Arentz [:st3fan] from comment #2)
> Why under a pref? It makes no sense to show this info. It is not part of the
> original response and has nothing to do with JSON.

Off by default.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Ignore non-enumerable properties

Sadly this patch isn't all that is needed for this bug. I'm trying to understand why the JSON object pane appears empty even though no error is thrown, but I'm failing so far.

Comment 6

[Victor Porof [:vporof][:vp]]

Might be a variables view bug. Since the structure is Scope -> empty variable -> properties, the empty variable might be considered non-enumerable, thus hidden, thus emptiness.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Hide non-enumerable properties of parsed JSON in the network details v2

This works and passes all tests.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/7be1beea5328

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7be1beea5328