862402 - [Settings][bluetooth] connected device will be shown disconnected after settings app killed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Paul Yang [:pyang] (away)]

Precondition:
Unagi with v1.0.1 nightly build
build id:20130415230202
Any bluetooth devices

reproduce steps:
1. search for target device in settings app
2. pair with target device; then manual or automatical connect it
3. verify if the device is connected 
4. long press home button to launch window manager
5. kill settings app in window manager
6. re-open settings app
7. in settings it shows device is disconnected (but paired)
8. click the device name, try to re-connect it;
9. pop-up a warning and fail to connected; 


Actually the connection remains but settings app gives a wrong status.

Comment 2

[Gina Yeh [:gyeh] [:ginayeh]]

Nominated as tef? since the connection status is out of sync after following STR, and the only way to fix it is to turn off and turn on Bluetooth again.

In details, the Bluetooth Headset had successfully connected to our FFos phone actually, but Settings app failed to get correct connection status when re-launching it and wrong options are shown for paired devices, i.e. 'Connect' and 'Unpair'. There's no way to disconnect with the Bluetooth Headset from FFos phone.

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

Add more details for STR:

(In reply to Paul Yang from comment #0)
> reproduce steps:
> 1. search for target device in settings app
> 2. pair with target device; then manual or automatical connect it
> 3. verify if the device is connected 
> 4. long press home button to launch window manager
> 5. kill settings app in window manager
> 6. re-open settings app
> 7. in settings it shows device is disconnected (but paired)
> 8. click the device name, try to re-connect it;
> 9. pop-up a warning and fail to connected; 
> 

Actully, we don't need to do Step 8 manually, and the warning described in Step 9 will be popped out automatically because Settings app will try to connect with the latest Bluetooth headset once we enter the Bluetooth subpage.

As a result, a warning window is shown immediately after entering Bluetooth subpage.

Comment 4

[Evelyn Hung]

(In reply to Gina Yeh [:gyeh] [:ginayeh] from comment #3)
> Add more details for STR:
> 
> (In reply to Paul Yang from comment #0)
> > reproduce steps:
> > 1. search for target device in settings app
> > 2. pair with target device; then manual or automatical connect it
> > 3. verify if the device is connected 
> > 4. long press home button to launch window manager
> > 5. kill settings app in window manager
> > 6. re-open settings app
> > 7. in settings it shows device is disconnected (but paired)
> > 8. click the device name, try to re-connect it;
> > 9. pop-up a warning and fail to connected; 
> > 
> 
> Actully, we don't need to do Step 8 manually, and the warning described in
> Step 9 will be popped out automatically because Settings app will try to
> connect with the latest Bluetooth headset once we enter the Bluetooth
> subpage.
> 
> As a result, a warning window is shown immediately after entering Bluetooth
> subpage.
Rewrite STR to make it clear:
1. pair with a headset in settings app, and see the headset is connected automatically
2. if not, manually connect it by one click and select 'connect'
3. verify if the device is connected 
4. long press home button to see app card view, and then kill Settings app
5. re-open Settings app

Expected:
 see the headset is still connected.

Actual:
 it shows disconnected (but paired), and a fail to connected window pops up.


Settings app can't acquire device connected/disconnected information now. However, it will try to restore connection at launch time if there was a connected headset before. So in this case, it's trying to connect a connected device and get an error from Gecko, and then the error window prompts.

(In reply to Gina Yeh [:gyeh] [:ginayeh] from comment #2)
> Nominated as tef? since the connection status is out of sync after following
> STR, and the only way to fix it is to turn off and turn on Bluetooth again.
> 
agree.

Comment 5

[Alex Keybl [:akeybl]]

Unless this ends up blocking certification, this bug isn't a blocker. Not user critical in any normal user scenario.

Comment 6

[Eric Chou [:ericchou] [:echou]]

Since bug 850157 has landed, we could start fixing this.

Comment 7

[Evelyn Hung]

Take because I have a WIP patch waiting for this API done.

Comment 8

[leo.bugzilla.gecko]

Dear Mozilaa Team,

Leo device is reproduced this bug.
Please check ASAP.

Thanks.

Comment 9

[Wayne Chang [:wchang]]

Triage Leo+ per comment 8 and partner milestone.

Comment 10

[bhavana bajaj [:bajaj]]

needsinfo Evelyn to get an update here as there was WIP patch per comment #7 and keeping in mind the priority as this is recently leo+ . Please let us know how the patch is progressing? Thanks !

Comment 11

[Evelyn Hung]

Sorry I didn't notice this issue is marked as leo+. I took this issue almost one month ago, and the WIP patch is totally not synced with the final landed API. I'd like to mentor someone to fix it. Re-assign this issue to Arthur first.

Comment 12

[leo.bugzilla.gecko]

Dear Mozilla Team,

Please let me know how the patch is progressing?

Thanks.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

I'll check it today. Thanks!

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/10010

Evelyn, please help review the change, thanks!

Comment 15

[Evelyn Hung]

Comment on attachment 754328 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/10010

r=me. tested and looks good. Thanks.

Comment 16

[Evelyn Hung]

merged int gaia-master:
https://github.com/mozilla-b2g/gaia/commit/794c2f30c19e0d219d7d3e7f21befad0bb1999c5

Comment 17

[Arthur Chen [:arthurcc][inactive after 6/30]]

v1-train: https://github.com/mozilla-b2g/gaia/commit/45f208a1fdad3a5b2e085c4172d247bc41230a60