862508 - Autophone - should specify user when launching Fennec on Android 4.2

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

Bug 838844 added the ability to specify the user when launching apps on Android 4.2. In Autophone we manually shell out to run 

exec "MOZ_CRASHREPORTER_NO_REPORT=1" am start -a android.intent.action.VIEW -n org.mozilla.fennec/.App --es args '--profile /storage/emulated/0/tests/autophone/profile' -d url

We need to either use mozdevice/droid.py's launchFennec or need to specify the user when launching fennec via shell. 

Is there any reason we aren't using launchFennec?

launchApplication also specifies -W (wait for launch to complete). Should we use that?

Comment 1

[William Lachance (:wlach)]

(In reply to Bob Clary [:bc:] from comment #0)

> Is there any reason we aren't using launchFennec?
> 
> launchApplication also specifies -W (wait for launch to complete). Should we
> use that?

I believe Autophone's app launching code was written before I wrote launchFennec/launchApplication. Of course I'm biased, but I think it would be great if you used it. ;)

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: patch v1

Use DroidSUT's launchFennec. I need to kill fennec before doing the launch due to an issue with Fennec being preloaded on Android 4.2/x86 and causing launchFennec to barf about multiple instances. Android 2.3/armv7 also appears to have the preloaded Fennec but SUT doesn't see it and doesn't barf. That is an issue I'd like to understand better but not here.

Comment 3

[Bob Clary [:bc] (inactive)]

I believe this is responsible for a significant regression in throbber start times. I am investigating whether the am -W option is responsible.

Comment 4

[Bob Clary [:bc] (inactive)]

Attachment: patch mozbase

Allow caller to specify whether to use -W to launch an app.

Comment 5

[Bob Clary [:bc] (inactive)]

Attachment: patch v2

Uses patched mozbase to allow us to specify whether to use -W to launch an fennec.

Comment 6

[William Lachance (:wlach)]

Comment on attachment 744104 [details] [diff] [review]
patch mozbase

Looks good, except for one docstring.

>diff --git a/mozdevice/mozdevice/droid.py b/mozdevice/mozdevice/droid.py
>+        :param wait: Boolean determining whether to pass -W to am

The fact that we use am under the hood is a bit of an implementation detail. Let's say something like "If True, wait for application to start before returning"

Comment 7

[Mark Côté [:mcote]]

Comment on attachment 744106 [details] [diff] [review]
patch v2

Review of attachment 744106 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Btw you can resolve bug 798854 at the same time as this, since this takes care of switching to DroidSUT.

Comment 8

[Bob Clary [:bc] (inactive)]

Attachment: merged patch

wlach, I had failed to merge with recent commits and had to deal with the new argument failIfRunning. I put wait in front of failIfRunning. If that's not ok, I'll move it to the end. just let me know which you prefer.

Comment 9

[William Lachance (:wlach)]

Comment on attachment 744147 [details] [diff] [review]
merged patch

It's all good to me. ;)

Comment 10

[Bob Clary [:bc] (inactive)]

thanks! https://github.com/mozilla/mozbase/commit/97e219af22a7e4930d6aae481f242fb308c8b0bb

Comment 11

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/873caf080651b3b1c3e036993077a4207426e112