86253 - characters in hebrew sometimes are shown as question marks "?"

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Alon Blayer-Gat]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC; en-US; rv:0.9.1) Gecko/20010607
BuildID:    2001060712

On the same pages the same hebrew letter can appear regularly or as a "?" will
show instead.
When selecting the word with the "?" letter - it convets back to the letter.


Reproducible: Always
Steps to Reproduce:
1. use a reguar hebrew font (come with the Hebrew language kit - from apple)
2. Use the Hebrew - ISO 8559-8 encoding
3. Use site http://www2.iol.co.il/communities/

Actual Results:  The description above

Expected Results:  Show the character

Comment 1

[Andreas Becker]

Changing component to "Bidi" and adding intl keyword.  Switching qa contact to
Gilad ([e-mail]).

Gilad, I tried displaying this page on MacOS 9.1, however it displayed (as far
as I could notice) fine.  Can you confirm this bug on the given MacOS system?

Comment 2

[nhottanscp]

Reassign to ftang.

Comment 3

[Frank Tang]

Mac and Hebrew/Arabic. Future it.

Comment 4

[Alon Blayer-Gat]

On http://www2.iol.co.il/communities/ the problem appears on the right side
(frame ??)
As I select the word with the "?" - the "?" travels from left to right - if I
select from right to left
And from right to left - if I select from left to right.

Also as I type free hebrew text (in a text box or the URL box (using a font
provided by Apple's Hebrew language kit) - many letters will appear as question
marks and when I type a letter that appears normaly, then all or some of the
question marks that came before it - change to the regular letters I actually typed.

Comment 5

[Alon Blayer-Gat]

Attachment: A screen shot of the "?" site

Comment 6

[Alon Blayer-Gat]

In the URL box the hebrew letters on the keys q,w,[,],',/,<space>,<delete> show
as question marks "?"
If I type another letter not from the one mentioned above after a "?" - the "?"
will diappear - and will show again if I delete that "good" letter.
If I type two or more letters that show as "?" then the first "good" letter I
type after that will show as "?" and the second will show regularly and also
will delete all "?" but one.
BTW - the "good" letters appear from right to left as they should but the "?"
will appear on the right side.

This will happens in any text box

Alon Blayer-Gat

Comment 7

[Zach Lipton [:zach]]

Mass-move all BiDi Hebrew and Arabic qa to me, [e-mail]. 
Thank you Gilad for your service to this component, and best of luck to you 
in the future.

Sholom. 

Comment 8

[Nissan Zafrir]

Attachment: HTML exmaple for the Questions Marks bug

see how questions marks appear in hebrew text ( logical & visual )

Comment 9

[Nissan Zafrir]

Attachment: SnapShot of the problem

I restarted my mac with system script set to Hebrew script.(
LanguageSwitch.app)
Using Force Roman Font in Text Control Panel , you'll see what the ? is about.

Comment 10

[Nissan Zafrir]

Questions marks , appears when there are break chars.
the question mark is acutally a hebrew char , which for some reason have been
draw with Roman font , and not hebrew.
(see snapshot attached)

how to reproduce: (html attached)
if i have a text line with hebrew , and in the middle of the line there
is a style change ( new run style ) then there is a potentiel for the bug.
now, if i add a break char ( space , comma , slash ) before the html token
for example  .<font size="6">   then the comma will cause the bug .

Inside the Code:
After watching the source ( i cant build it right now  , waiting for CW 7 switch on 3/12)
i think the problem is somewhere in : nsUnicodeRenderingToolkit::DrawString
where this text appear :
if (aSpacing)
  {
    // fix me ftang -  handle (mRightToLeftText) here

anyway , i think that in DrawString , when using aSpacing , the code is changing font
for every contextual chars, format control chars & combining chars .
while when drawing without spacing , font is changed only for format control chars.

maybe , the first char of the segment is assigned with roman font for some reason.

Nissan.

Comment 11

[Frank Tang]

could be a dup of 117028

Comment 12

[Frank Tang]

I believe the following three patch should fix most mac os hewbrew problem

big endian issue in nsFrame.cpp
see latest patch in http://bugzilla.mozilla.org/show_bug.cgi?id=116976

big endian issue in nsBidiImp.cpp 
http://bugzilla.mozilla.org/attachment.cgi?id=62917&action=view

turn off hebrew reordering and do not report hint on mac gfx
http://bugzilla.mozilla.org/attachment.cgi?id=62920&action=view

Comment 13

[Frank Tang]

this should be fixed right now.