Fix some warnings in SIPCC Android code

RESOLVED FIXED in Firefox 23

Status

()

defect
P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

(Blocks 1 bug)

unspecified
mozilla23
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox22 affected, firefox23 fixed)

Details

(Whiteboard: [WebRTC][blocking-webrtc-][android-webrtc+][qa-])

Attachments

(1 attachment)

The -Wdeclaration-after-statement warnings are not a big deal, but the incompatible pointer type warning looks like gettimeofday() could write to random memory because cprGetMessage() is passing a struct timezone** instead of a struct timezone*.

media/webrtc/signaling/src/sipcc/cpr/android/cpr_android_ipc.c:194:2 [-Wdeclaration-after-statement] ISO C90 forbids mixed declarations and code
media/webrtc/signaling/src/sipcc/cpr/android/cpr_android_ipc.c:196:2 [-Wdeclaration-after-statement] ISO C90 forbids mixed declarations and code
media/webrtc/signaling/src/sipcc/cpr/android/cpr_android_ipc.c:349:3 [enabled by default] passing argument 2 of 'gettimeofday' from incompatible pointer type
Attachment #738330 - Flags: review?(rjesup)
Attachment #738330 - Flags: review?(rjesup) → review+
Priority: -- → P1
Whiteboard: [WebRTC][blocking-webrtc-][android-webrtc+]
https://hg.mozilla.org/mozilla-central/rev/792caadb8422
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [WebRTC][blocking-webrtc-][android-webrtc+] → [WebRTC][blocking-webrtc-][android-webrtc+][qa-]
You need to log in before you can comment on or make changes to this bug.