Closed
Bug 862669
Opened 12 years ago
Closed 12 years ago
Fix some warnings in SIPCC Android code
Categories
(Core :: WebRTC: Signaling, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
(Whiteboard: [WebRTC][blocking-webrtc-][android-webrtc+][qa-])
Attachments
(1 file)
|
2.81 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
The -Wdeclaration-after-statement warnings are not a big deal, but the incompatible pointer type warning looks like gettimeofday() could write to random memory because cprGetMessage() is passing a struct timezone** instead of a struct timezone*.
media/webrtc/signaling/src/sipcc/cpr/android/cpr_android_ipc.c:194:2 [-Wdeclaration-after-statement] ISO C90 forbids mixed declarations and code
media/webrtc/signaling/src/sipcc/cpr/android/cpr_android_ipc.c:196:2 [-Wdeclaration-after-statement] ISO C90 forbids mixed declarations and code
media/webrtc/signaling/src/sipcc/cpr/android/cpr_android_ipc.c:349:3 [enabled by default] passing argument 2 of 'gettimeofday' from incompatible pointer type
Attachment #738330 -
Flags: review?(rjesup)
|
||
Updated•12 years ago
|
Attachment #738330 -
Flags: review?(rjesup) → review+
|
|
||
Updated•12 years ago
|
Priority: -- → P1
Whiteboard: [WebRTC][blocking-webrtc-][android-webrtc+]
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Whiteboard: [WebRTC][blocking-webrtc-][android-webrtc+] → [WebRTC][blocking-webrtc-][android-webrtc+][qa-]
|
|
||
Updated•12 years ago
|
Blocks: android-webrtc
You need to log in
before you can comment on or make changes to this bug.
Description
•