Closed Bug 862673 Opened 7 years ago Closed 7 years ago

Assertions in test_mousecapture_area.html incorrectly attributed to following test

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: markh, Assigned: markh)

Details

Attachments

(1 file)

toolkit/content/tests/widgets/test_mousecapture_area.html causes a number of assertions, but 2 of them happen after the test has finished, causing them to be attributed to the following test (which is currently test_videocontrols.html).  This means adding a new test that happens to fall between these 2 tests is a problem, as the assertions are then attributed to the new test.

A simple change to test_mousecapture_area.html - removing the test images from the DOM at the end of the test - causes the assertions to happen while the mousecapture test is running, which isn't as good as avoiding the assertions entirely, but seems better than blaming the wrong test.
This patch removes content before finishing the test to avoid the next test being blamed for the assertions.  Also removes the expected assertion count from the text that happens to currently be next.

Try at https://tbpl.mozilla.org/?tree=Try&rev=3269a6e4f6f8
Assignee: nobody → mhammond
Attachment #738358 - Flags: review?
Attachment #738358 - Flags: review? → review+
https://hg.mozilla.org/mozilla-central/rev/28af81b415ab
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.